From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH 5/5][NFS] Cleanup explicit check for mandatory locks
Date: Tue, 18 Sep 2007 09:27:15 -0400 [thread overview]
Message-ID: <1190122035.6665.15.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <46EF6E18.90801@openvz.org>
On Tue, 2007-09-18 at 10:20 +0400, Pavel Emelyanov wrote:
> Trond Myklebust wrote:
> > On Mon, 2007-09-17 at 11:57 +0400, Pavel Emelyanov wrote:
> >> The __mandatory_lock(inode) macro makes the same check, but
> >> makes the code more readable.
> >
> > Could we please avoid using underscores in macros. Also, why are we
> > breaking the usual convention of capitalising macro names?
>
> Sorry, I've forgot to change all the log - this is not a macro,
> but a static inline function. The underscores are here, because
> the mandatory_lock() one already exists and additionally checks
> for "if (IS_MANDLOCK(inode))"
OK. I withdraw my objection then.
Cheers
Trond
prev parent reply other threads:[~2007-09-18 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 7:57 Pavel Emelyanov
2007-09-17 17:03 ` Trond Myklebust
2007-09-18 6:20 ` Pavel Emelyanov
2007-09-18 13:27 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190122035.6665.15.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®