From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: hch@infradead.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [patch 3/5] VFS: pass open file to ->xattr()
Date: Fri, 21 Sep 2007 10:32:31 -0400 [thread overview]
Message-ID: <1190385151.6680.35.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <E1IYiN2-0001eq-00@dorka.pomaz.szeredi.hu>
On Fri, 2007-09-21 at 15:16 +0200, Miklos Szeredi wrote:
> > ftruncate is a special case due to O_TRUNC.
>
> No, it's special, because it does not do permission checking, while
> truncate() does.
So why not just add file->f_op->ftruncate() and file->f_op->fstat()?
Most filesystems can trivially redirect these to do_truncate() and their
existing getattr() method. Those, like FUSE, that care can use the hook.
In fact, I think that NFSv4 could also benefit from an ftruncate():
currently we have to hunt around for an open file context for that
particular case.
Trond
next prev parent reply other threads:[~2007-09-21 14:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 12:23 [patch 0/5] VFS changes Miklos Szeredi
2007-09-21 12:23 ` [patch 1/5] VFS: pass open file to ->setattr() Miklos Szeredi
2007-09-21 12:23 ` [patch 2/5] VFS: pass open file to ->getattr() Miklos Szeredi
2007-09-21 18:37 ` Andreas Dilger
2007-09-21 21:07 ` Miklos Szeredi
2007-09-21 12:23 ` [patch 3/5] VFS: pass open file to ->xattr() Miklos Szeredi
2007-09-21 12:43 ` Christoph Hellwig
2007-09-21 13:00 ` Miklos Szeredi
2007-09-21 13:06 ` Christoph Hellwig
2007-09-21 13:16 ` Miklos Szeredi
2007-09-21 14:32 ` Trond Myklebust [this message]
2007-09-21 14:34 ` Christoph Hellwig
2007-09-21 14:59 ` Miklos Szeredi
2007-09-21 18:44 ` Andreas Dilger
2007-09-21 21:15 ` Miklos Szeredi
2007-09-21 14:43 ` Miklos Szeredi
2007-09-21 18:39 ` Andreas Dilger
2007-09-21 12:23 ` [patch 4/5] VFS: allow filesystems to implement atomic open+truncate Miklos Szeredi
2007-09-21 12:44 ` Christoph Hellwig
2007-09-21 13:01 ` Miklos Szeredi
2007-09-21 18:47 ` Andreas Dilger
2007-09-21 12:23 ` [patch 5/5] VFS: allow filesystem to override mknod capability checks Miklos Szeredi
2007-09-21 12:45 ` Christoph Hellwig
2007-09-21 13:10 ` Miklos Szeredi
2007-09-21 13:14 ` Christoph Hellwig
2007-09-21 13:18 ` Miklos Szeredi
2007-09-21 14:33 ` Christoph Hellwig
2007-09-21 14:48 ` Miklos Szeredi
2007-09-21 14:53 ` Christoph Hellwig
2007-09-21 15:11 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190385151.6680.35.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®