mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Cheng <crquan@gmail.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, cr_quan@163.com
Subject: [PATCH] fs/dcache.c: revamped to use a more straightforward and efficient way to operate
Date: Wed, 26 Sep 2007 04:04:30 +0800	[thread overview]
Message-ID: <1190750670-8264-1-git-send-email-crquan@gmail.com> (raw)
In-Reply-To: <1190546051-15590-1-git-send-email-crquan@gmail.com>

Signed-off-by: Denis Cheng <crquan@gmail.com>
---
 fs/dcache.c |   39 ++++++++++++++++++---------------------
 1 files changed, 18 insertions(+), 21 deletions(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 678d39d..05ed44a 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1138,29 +1138,26 @@ struct dentry * d_alloc_anon(struct inode *inode)
 	
 	spin_lock(&dcache_lock);
 	res = __d_find_alias(inode, 0);
-	if (!res) {
-		/* attach a disconnected dentry */
-		res = tmp;
-		tmp = NULL;
-		spin_lock(&res->d_lock);
-		res->d_sb = inode->i_sb;
-		res->d_parent = res;
-		res->d_inode = inode;
-		res->d_flags |= DCACHE_DISCONNECTED;
-		res->d_flags &= ~DCACHE_UNHASHED;
-		list_add(&res->d_alias, &inode->i_dentry);
-		hlist_add_head(&res->d_hash, &inode->i_sb->s_anon);
-		spin_unlock(&res->d_lock);
-
-		inode = NULL; /* don't drop reference */
-	}
-	spin_unlock(&dcache_lock);
-
-	if (inode)
+	if (unlikely(res)) {
+		spin_unlock(&dcache_lock);
 		iput(inode);
-	if (tmp)
 		dput(tmp);
-	return res;
+		return res;
+	} else {
+		/* attach a disconnected dentry */
+		spin_lock(&tmp->d_lock);
+		tmp->d_sb = inode->i_sb;
+		tmp->d_parent = tmp;
+		tmp->d_inode = inode;
+		tmp->d_flags |= DCACHE_DISCONNECTED;
+		tmp->d_flags &= ~DCACHE_UNHASHED;
+		list_add(&tmp->d_alias, &inode->i_dentry);
+		hlist_add_head(&tmp->d_hash, &inode->i_sb->s_anon);
+		spin_unlock(&tmp->d_lock);
+
+		spin_unlock(&dcache_lock);
+		return tmp;
+	}
 }
 
 
-- 
1.5.3.2


  reply	other threads:[~2007-09-25 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 11:14 [PATCH] vfs: use the predefined d_unhashed inline function instead Denis Cheng
2007-09-25 20:04 ` Denis Cheng [this message]
2007-10-01 17:25   ` [PATCH] fs/dcache.c: revamped to use a more straightforward and efficient way to operate Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1190750670-8264-1-git-send-email-crquan@gmail.com \
    --to=crquan@gmail.com \
    --cc=cr_quan@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®