From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755100AbXIZB5U (ORCPT ); Tue, 25 Sep 2007 21:57:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753233AbXIZB5G (ORCPT ); Tue, 25 Sep 2007 21:57:06 -0400 Received: from hancock.steeleye.com ([71.30.118.248]:55706 "EHLO hancock.sc.steeleye.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752942AbXIZB5E (ORCPT ); Tue, 25 Sep 2007 21:57:04 -0400 Subject: Re: [GIT PATCH] SCSI bug fix for 2.6.23-rc8 From: James Bottomley To: Andrew Morton Cc: Linus Torvalds , linux-scsi , linux-kernel In-Reply-To: <1190742924.3345.42.camel@localhost.localdomain> References: <1190742924.3345.42.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 25 Sep 2007 20:57:01 -0500 Message-Id: <1190771821.8707.25.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2007-09-25 at 12:55 -0500, James Bottomley wrote: > This is, unfortunately, not a recent regression but it's only been > recently diagnosed. Apparently the SCSI Parallel transport class domain > validation cable width detection wasn't working, leading to cases where > controllers with damaged cables would end up hanging the system (the > reported one was an aic79xx controller, but the potential is there for > all SPI based systems). This bug would *only* affect systems whose > cable integrity or connectors were compromised, so it isn't life > threatening to every SCSI Parallel installation, but the consequence of > running into it is a system hang. > > The fix is available here: > > master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git > > The short changelog is: > > James Bottomley (1): > scsi_transport_spi: fix domain validation failure from incorrect > width setting > > And the diffstat: > > scsi_transport_spi.c | 28 ++++++++++++++++++++++------ > 1 file changed, 22 insertions(+), 6 deletions(-) We've had another late arriving bug fix: commit ff4abd6cfacf0bb23a077f615d3a5cd17359db1b Author: David Miller Date: Fri Aug 24 22:25:58 2007 -0700 [SCSI] esp: fix instance numbering. Because the ->unique_id is set too late, the ESP scsi host instance numbers in the kernel log during probing are wrong. Bug reported by Meelis Roos. Signed-off-by: David S. Miller Signed-off-by: James Bottomley Which I've added. The diffstat is now: esp_scsi.c | 3 ++- scsi_transport_spi.c | 28 ++++++++++++++++++++++------ 2 files changed, 24 insertions(+), 7 deletions(-) James