From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
Thierry MERLE <thierry.merle@free.fr>
Subject: Re: [PATCH] usbvision-video: buggered method tables
Date: Wed, 26 Sep 2007 10:02:25 -0300 [thread overview]
Message-ID: <1190811745.5076.4.camel@gaivota> (raw)
In-Reply-To: <E1IaL9q-00084l-9L@ZenIV.linux.org.uk>
Em Qua, 2007-09-26 às 01:53 +0100, Al Viro escreveu:
> duplicated .mmap in one, .vidioc_s_audio misspelled as .vidioc_g_audio
> in other
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
> ---
> drivers/media/video/usbvision/usbvision-video.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
> index e3371f9..0cb006f 100644
> --- a/drivers/media/video/usbvision/usbvision-video.c
> +++ b/drivers/media/video/usbvision/usbvision-video.c
> @@ -1387,7 +1387,6 @@ static const struct file_operations usbvision_fops = {
> .ioctl = video_ioctl2,
> .llseek = no_llseek,
> /* .poll = video_poll, */
> - .mmap = usbvision_v4l2_mmap,
> .compat_ioctl = v4l_compat_ioctl32,
> };
> static struct video_device usbvision_video_template = {
> @@ -1413,7 +1412,7 @@ static struct video_device usbvision_video_template = {
> .vidioc_s_input = vidioc_s_input,
> .vidioc_queryctrl = vidioc_queryctrl,
> .vidioc_g_audio = vidioc_g_audio,
> - .vidioc_g_audio = vidioc_s_audio,
> + .vidioc_s_audio = vidioc_s_audio,
> .vidioc_g_ctrl = vidioc_g_ctrl,
> .vidioc_s_ctrl = vidioc_s_ctrl,
> .vidioc_streamon = vidioc_streamon,
> @@ -1459,7 +1458,7 @@ static struct video_device usbvision_radio_template=
> .vidioc_s_input = vidioc_s_input,
> .vidioc_queryctrl = vidioc_queryctrl,
> .vidioc_g_audio = vidioc_g_audio,
> - .vidioc_g_audio = vidioc_s_audio,
> + .vidioc_s_audio = vidioc_s_audio,
> .vidioc_g_ctrl = vidioc_g_ctrl,
> .vidioc_s_ctrl = vidioc_s_ctrl,
> .vidioc_g_tuner = vidioc_g_tuner,
--
Cheers,
Mauro
prev parent reply other threads:[~2007-09-26 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 0:53 Al Viro
2007-09-26 13:02 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190811745.5076.4.camel@gaivota \
--to=mchehab@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.merle@free.fr \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®