mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric St-Laurent <ericstl34@sympatico.ca>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Mike Galbraith <efault@gmx.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Dmitry Adamushko <dmitry.adamushko@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>,
	maneesh@linux.vnet.ibm.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Sudhir Kumar <skumar@linux.vnet.ibm.com>
Subject: Re: [RFC/PATCH] Add sysfs control to modify a user's cpu share
Date: Tue, 02 Oct 2007 18:12:39 -0400	[thread overview]
Message-ID: <1191363159.29539.15.camel@perkele> (raw)
In-Reply-To: <20071001144402.GA3505@elte.hu>


On Mon, 2007-10-01 at 16:44 +0200, Ingo Molnar wrote:
> > Adds tunables in sysfs to modify a user's cpu share.
> > 
> > A directory is created in sysfs for each new user in the system.
> > 
> > 	/sys/kernel/uids/<uid>/cpu_share
> > 
> > Reading this file returns the cpu shares granted for the user.
> > Writing into this file modifies the cpu share for the user. Only an 
> > administrator is allowed to modify a user's cpu share.
> > 
> > Ex: 
> > 	# cd /sys/kernel/uids/
> > 	# cat 512/cpu_share
> > 	1024
> > 	# echo 2048 > 512/cpu_share
> > 	# cat 512/cpu_share
> > 	2048
> > 	#
> 
> looks good to me! I think this API is pretty straightforward. I've put 
> this into my tree and have updated the sched-devel git tree:
> 

While a sysfs interface is OK and somewhat orthogonal to the interface
proposed the containers patches, I think maybe a new syscall should be
considered.

Since we now have a fair share cpu scheduler, maybe an interface to
specify the cpu share directly (alternatively to priority) make sense.

For processes, it may become more intuitive (and precise) to set the
processing share directly than setting a priority which is converted to
a share.

Maybe something similar to ioprio_set() and ioprio_get() syscalls:

- per user cpu share
- per user group cpu share
- per process cpu share
- per process group cpu share


Best regards,

- Eric



  parent reply	other threads:[~2007-10-02 22:12 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24 21:45 [git] CFS-devel, latest code Ingo Molnar
2007-09-24 21:55 ` Andrew Morton
2007-09-24 21:59   ` Ingo Molnar
2007-09-25  0:08 ` Daniel Walker
2007-09-25  6:45   ` Ingo Molnar
2007-09-25 15:17     ` Daniel Walker
2007-09-25  6:10 ` Mike Galbraith
2007-09-25  7:35   ` Mike Galbraith
2007-09-25  8:33     ` Mike Galbraith
2007-09-25  8:53       ` Srivatsa Vaddagiri
2007-09-25  9:11         ` Srivatsa Vaddagiri
2007-09-25  9:15           ` Mike Galbraith
2007-09-25  9:12         ` Mike Galbraith
2007-09-25  9:13       ` Ingo Molnar
2007-09-25  9:17         ` Mike Galbraith
2007-09-25  9:47           ` Ingo Molnar
2007-09-25 10:02             ` Mike Galbraith
2007-09-26  8:04             ` Mike Galbraith
2007-09-28 21:46             ` Bill Davidsen
2007-09-25  9:44         ` Srivatsa Vaddagiri
2007-09-25  9:40           ` Ingo Molnar
2007-09-25 10:10             ` Ingo Molnar
2007-09-25 10:28               ` Srivatsa Vaddagiri
2007-09-25 10:36                 ` Ingo Molnar
2007-09-25 11:33                   ` Ingo Molnar
2007-09-25 14:48                     ` Srivatsa Vaddagiri
2007-09-25 12:51                   ` Srivatsa Vaddagiri
2007-09-25 13:35                     ` Mike Galbraith
2007-09-25 14:07                       ` Srivatsa Vaddagiri
2007-09-25 12:28                 ` Mike Galbraith
2007-09-25 12:54                   ` Mike Galbraith
     [not found]                     ` <20070925131717.GM26289@linux.vnet.ibm.com>
     [not found]                       ` <1190725693.13716.10.camel@Homer.simpson.net>
     [not found]                         ` <20070925132528.GN26289@linux.vnet.ibm.com>
     [not found]                           ` <1190726682.11260.1.camel@Homer.simpson.net>
     [not found]                             ` <20070925140559.GB26310@linux.vnet.ibm.com>
     [not found]                               ` <20070925143755.GA15594@elte.hu>
     [not found]                                 ` <20070926210737.GA8663@elte.hu>
2007-10-01 14:04                                   ` [RFC/PATCH] Add sysfs control to modify a user's cpu share Dhaval Giani
2007-10-01 14:44                                     ` Ingo Molnar
2007-10-01 15:32                                       ` Srivatsa Vaddagiri
2007-10-02 22:12                                       ` Eric St-Laurent [this message]
2007-10-03  4:09                                         ` Srivatsa Vaddagiri
2007-10-03 17:10                                       ` [RFC/PATCH -v2] " Dhaval Giani
2007-10-04  7:57                                         ` Ingo Molnar
2007-10-04  8:54                                           ` Heiko Carstens
2007-10-04 16:02                                             ` Bill Davidsen
2007-10-04 17:20                                               ` Srivatsa Vaddagiri
2007-10-04 21:32                                             ` Valdis.Kletnieks
2007-10-05  7:01                                               ` Srivatsa Vaddagiri
2007-10-09 15:12                                             ` [PATCH sched-devel] Generate uevents for user creation/destruction Srivatsa Vaddagiri
2007-10-10  7:42                                               ` Ingo Molnar
2007-10-01 16:12                                     ` [RFC/PATCH] Add sysfs control to modify a user's cpu share Dave Jones
2007-10-01 16:37                                       ` Srivatsa Vaddagiri
2007-09-25  6:50 ` [git] CFS-devel, latest code S.Çağlar Onur
2007-09-25  9:17   ` Ingo Molnar
2007-09-25  7:41 ` Andrew Morton
2007-09-25  8:43   ` Srivatsa Vaddagiri
2007-09-25  8:48     ` Andrew Morton
2007-09-25 11:00     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1191363159.29539.15.camel@perkele \
    --to=ericstl34@sympatico.ca \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=dmitry.adamushko@gmail.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maneesh@linux.vnet.ibm.com \
    --cc=mingo@elte.hu \
    --cc=skumar@linux.vnet.ibm.com \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®