mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan Wu <bryan.wu@analog.com>
To: David Brownell <david-b@pacbell.net>
Cc: Bryan Wu <bryan.wu@analog.com>,
	spi-devel-general@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/9] Blackfin SPI driver: use new GPIO API and add error handling
Date: Fri, 12 Oct 2007 10:59:28 +0800	[thread overview]
Message-ID: <1192157968.6247.1.camel@roc-laptop> (raw)
In-Reply-To: <200710111446.29725.david-b@pacbell.net>

On Thu, 2007-10-11 at 14:46 -0700, David Brownell wrote:
> On Thursday 11 October 2007, Bryan Wu wrote:
> > @@ -1182,12 +1198,9 @@ static int __init bfin5xx_spi_probe(struct platform_device *pdev)
> >                 return -ENOMEM;
> >         }
> >  
> > -       if (peripheral_request(P_SPI0_SCK, DRV_NAME) ||
> > -                peripheral_request(P_SPI0_MISO, DRV_NAME) ||
> > -                peripheral_request(P_SPI0_MOSI, DRV_NAME) ) {
> > -
> > +       if (setup_pin_mux(1)) {
> >                 dev_err(&pdev->dev, ": Requesting Peripherals failed\n");
> > -               goto out_error_queue_alloc;
> > +               goto out_error;
> >         }
> >  
> >         drv_data = spi_master_get_devdata(master);
> 
> 
> This doesn't apply against 2.6.23 ... ?

Oops, I missed the first patch in this patch series.
It will be sent as soon as possible.

Thanks a lot
-Bryan

  reply	other threads:[~2007-10-12  2:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 10:10 [PATCH 00/09] Blackfin SPI driver updates for 2.6.24 Bryan Wu
2007-10-11 10:10 ` [PATCH 1/9] Blackfin SPI driver: use new GPIO API and add error handling Bryan Wu
2007-10-11 21:46   ` David Brownell
2007-10-12  2:59     ` Bryan Wu [this message]
2007-10-11 10:10 ` [PATCH 2/9] Blackfin SPI driver: add error handing Bryan Wu
2007-10-11 10:10 ` [PATCH 3/9] Blackfin SPI driver: Blackfin SPI driver does not respect the per-transfer cs_change field Bryan Wu
2007-10-11 10:10 ` [PATCH 4/9] Blackfin SPI driver: prevent people from setting bits in ctl_reg Bryan Wu
2007-10-11 10:10 ` [PATCH 5/9] Blackfin SPI driver: update spi driver to support multi-ports Bryan Wu
2007-10-11 10:10 ` [PATCH 6/9] Blackfin SPI driver: Add SPI master controller platform device 1 Bryan Wu
2007-10-11 10:10 ` [PATCH 7/9] Blackfin SPI driver: Move GPIO config to setup and cleanup Bryan Wu
2007-10-11 10:10 ` [PATCH 8/9] Blackfin SPI driver: Fix SPI driver to work with SPI flash ST25P16 on bf548 Bryan Wu
2007-10-11 10:10 ` [PATCH 9/9] Blackfin SPI driver: Clean up useless wait in bfin SPI driver Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192157968.6247.1.camel@roc-laptop \
    --to=bryan.wu@analog.com \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome