mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Sébastien Dugué" <sebastien.dugue@bull.net>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Linux RT Users" <linux-rt-users@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RT: fix spin_trylock_irq
Date: Mon, 15 Oct 2007 13:06:56 -0700	[thread overview]
Message-ID: <1192478816.17527.58.camel@imap.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0710151406230.26495@gandalf.stny.rr.com>

On Mon, 2007-10-15 at 14:14 -0400, Steven Rostedt wrote:

> > This is the second fix for this .. The first was in this email (over a
> > month ago)
> >
> > http://lkml.org/lkml/2007/8/31/318
> 
> You're right I missed that. (I even read it). But for fixes like this, (or
> any patches that are not in the tree), you really need to resend the
> series.

In hindsight I should have resent, but I didn't .. Really it's a matter
of frustration on my part. Where I submit patches that should be
included , but they are ignored for no clear reason .. Then I submit
again, and the patches are ignored again for no clear reason..

Comparing mainline and -rt isn't very interesting since , -rt has few
patches sent in against it .. Andrew is bound to loose a patch here and
there on accident, but -rt has so few patches sent in that we shouldn't
be loosing any.

> When Ingo posts patches to LKML on CFS, if there's a little fix like this,
> he'll add that to his next queue and repost.

That's a git tree tho , so apples and oranges ..

> >
> > The above was emailed to Thomas, but I also sent you that link in IRC as
> > a link of patches to include .. I'll be happy to audit my code better,
> > but you should also audit your inclusion process better.. There have
> > been too many missed patches, and too many double and triples fixes..
> 
> There wouldn't be if we didn't have to go looking for patches on patches
> that are out of the series. If you see that a series is broken, don't
> patch against it. Resend the series!

In all fairness you asked for links to patches, and that's is what I
gave you ..

> Patches must be against upstream, unless they are more RFC (like what
> Gregory is doing). But when you want them to go upstream, they must be
> against upstream.  I don't have the time to look for little fixes that
> you've done to your own patches that have not been pulled in yet.

Not sure what your getting at.. I specifically directed you to a patch.
I don't think that means you had to look for it, all you have to do was
include it ..

Daniel


  reply	other threads:[~2007-10-15 20:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-11 12:24 Sébastien Dugué
2007-10-11 14:49 ` Steven Rostedt
2007-10-15 17:44   ` Daniel Walker
2007-10-15 18:14     ` Steven Rostedt
2007-10-15 20:06       ` Daniel Walker [this message]
2007-10-15 21:35         ` Thomas Gleixner
2007-10-15 21:44           ` Daniel Walker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192478816.17527.58.camel@imap.mvista.com \
    --to=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=sebastien.dugue@bull.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®