From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] nfs: fix nfs_writepage()
Date: Wed, 17 Oct 2007 11:45:17 -0400 [thread overview]
Message-ID: <1192635917.7573.24.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <1192635028.27435.137.camel@twins>
On Wed, 2007-10-17 at 17:30 +0200, Peter Zijlstra wrote:
> The thing is, swapper_space just calls ->writepage() and expects the
> page to be written out. So either the a_ops usage of swapper_space is
> deviant or NFS' is.
Could somebody please document WTF writepage() is supposed to do, and
WTF page_mkwrite() is for?
I thought that page_mkwrite() was supposed to finally allow us to deal
with dirty pages in a clean manner: the caller gets to tell the
filesystem that it wants the entire page written out, and then dirties
the page. What is the point if the VM then expects to be able to
circumvent this?
Trond
next prev parent reply other threads:[~2007-10-17 15:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 13:40 Peter Zijlstra
2007-10-17 15:25 ` Trond Myklebust
2007-10-17 15:30 ` Peter Zijlstra
2007-10-17 15:45 ` Trond Myklebust [this message]
2007-10-17 15:47 ` Trond Myklebust
2007-10-17 15:55 ` Christoph Hellwig
2007-10-17 16:02 ` Peter Zijlstra
2007-10-17 16:05 ` Christoph Hellwig
2007-10-17 15:57 ` Peter Zijlstra
2007-10-17 16:24 ` Trond Myklebust
2007-10-17 16:26 ` Peter Zijlstra
2007-10-17 17:36 ` Peter Zijlstra
2007-10-17 18:49 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192635917.7573.24.camel@heimdal.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®