From: James Bottomley <James.Bottomley@SteelEye.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: yokota@netlab.is.tsukuba.ac.jp, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] nsp32_restart_autoscsi(): remove error check
Date: Wed, 24 Oct 2007 12:41:12 -0400 [thread overview]
Message-ID: <1193244072.3396.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20071024162515.GV30533@stusta.de>
On Wed, 2007-10-24 at 18:25 +0200, Adrian Bunk wrote:
> The Coverity checker noted that we'll anyway Oops later when we ran into
> this condition - and the error check didn't prevent that.
>
> Considering that the error condition shouldn't be possible, and we are
> not able to handle it easily, this patch simply removes the pointless
> error check.
This is the one where I said I don't like the fact that you're removing
the explanatory message that's printed before we crash. if you want to
shut coverity up and stop sending the patch, I'm happy adding a BUG();
after the nsp32_msg().
James
next prev parent reply other threads:[~2007-10-24 16:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:25 Adrian Bunk
2007-10-24 16:41 ` James Bottomley [this message]
2007-10-24 16:54 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2007-07-23 19:33 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193244072.3396.17.camel@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome