From: Emil Medve <Emilian.Medve@Freescale.com>
To: mochel@osdl.org, gregkh@suse.de, linux-kernel@vger.kernel.org,
hjlipp@web.de, tilman@imap.cc,
gigaset307x-common@lists.sourceforge.net, kkeil@suse.de,
isdn4linux@listserv.isdn4linux.de, mac@melware.de,
linux-omap-open-source@linux.omap.com
Cc: Emil Medve <Emilian.Medve@Freescale.com>
Subject: [PATCH resend] Make the dev_*() family of macros in device.h complete
Date: Mon, 29 Oct 2007 17:43:15 -0500 [thread overview]
Message-ID: <1193697795-7823-1-git-send-email-Emilian.Medve@Freescale.com> (raw)
Removed duplicates defined elsewhere
Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
---
Reseding the patch to a larger audience
The macros are defined in the relative order KERN_* are defined in kernel.h
linux-2.6> scripts/checkpatch.pl 0001-Make-the-dev_-family-of-macros-in-device.h-comple.patch
Your patch has no obvious style problems and is ready for submission.
drivers/i2c/chips/isp1301_omap.c | 6 ------
drivers/isdn/gigaset/gigaset.h | 6 ------
include/linux/device.h | 26 ++++++++++++++++----------
3 files changed, 16 insertions(+), 22 deletions(-)
diff --git a/drivers/i2c/chips/isp1301_omap.c b/drivers/i2c/chips/isp1301_omap.c
index fe04e46..35b9909 100644
--- a/drivers/i2c/chips/isp1301_omap.c
+++ b/drivers/i2c/chips/isp1301_omap.c
@@ -259,12 +259,6 @@ static inline const char *state_name(struct isp1301 *isp)
return state_string(isp->otg.state);
}
-#ifdef VERBOSE
-#define dev_vdbg dev_dbg
-#else
-#define dev_vdbg(dev, fmt, arg...) do{}while(0)
-#endif
-
/*-------------------------------------------------------------------------*/
/* NOTE: some of this ISP1301 setup is specific to H2 boards;
diff --git a/drivers/isdn/gigaset/gigaset.h b/drivers/isdn/gigaset/gigaset.h
index a0317ab..02bdaf2 100644
--- a/drivers/isdn/gigaset/gigaset.h
+++ b/drivers/isdn/gigaset/gigaset.h
@@ -106,12 +106,6 @@ enum debuglevel {
activated */
};
-/* missing from linux/device.h ... */
-#ifndef dev_notice
-#define dev_notice(dev, format, arg...) \
- dev_printk(KERN_NOTICE , dev , format , ## arg)
-#endif
-
/* Kernel message macros for situations where dev_printk and friends cannot be
* used for lack of reliable access to a device structure.
* linux/usb.h already contains these but in an obsolete form which clutters
diff --git a/include/linux/device.h b/include/linux/device.h
index 2e15822..e4f8a1c 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -557,9 +557,24 @@ extern const char *dev_driver_string(struct device *dev);
#define dev_printk(level, dev, format, arg...) \
printk(level "%s %s: " format , dev_driver_string(dev) , (dev)->bus_id , ## arg)
+#define dev_emerg(dev, format, arg...) \
+ dev_printk(KERN_EMERG, dev, format, ## arg)
+#define dev_alert(dev, format, arg...) \
+ dev_printk(KERN_ALERT, dev, format, ## arg)
+#define dev_crit(dev, format, arg...) \
+ dev_printk(KERN_CRIT, dev, format, ## arg)
+#define dev_err(dev, format, arg...) \
+ dev_printk(KERN_ERR, dev, format, ## arg)
+#define dev_warn(dev, format, arg...) \
+ dev_printk(KERN_WARNING, dev, format, ## arg)
+#define dev_notice(dev, format, arg...) \
+ dev_printk(KERN_NOTICE, dev, format, ## arg)
+#define dev_info(dev, format, arg...) \
+ dev_printk(KERN_INFO, dev, format, ## arg)
+
#ifdef DEBUG
#define dev_dbg(dev, format, arg...) \
- dev_printk(KERN_DEBUG , dev , format , ## arg)
+ dev_printk(KERN_DEBUG, dev, format, ## arg)
#else
static inline int __attribute__ ((format (printf, 2, 3)))
dev_dbg(struct device * dev, const char * fmt, ...)
@@ -578,15 +593,6 @@ dev_vdbg(struct device * dev, const char * fmt, ...)
}
#endif
-#define dev_err(dev, format, arg...) \
- dev_printk(KERN_ERR , dev , format , ## arg)
-#define dev_info(dev, format, arg...) \
- dev_printk(KERN_INFO , dev , format , ## arg)
-#define dev_warn(dev, format, arg...) \
- dev_printk(KERN_WARNING , dev , format , ## arg)
-#define dev_notice(dev, format, arg...) \
- dev_printk(KERN_NOTICE , dev , format , ## arg)
-
/* Create alias, so I can be autoloaded. */
#define MODULE_ALIAS_CHARDEV(major,minor) \
MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor))
--
1.5.3.GIT
next reply other threads:[~2007-10-29 22:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 22:43 Emil Medve [this message]
2007-10-29 23:08 ` Tilman Schmidt
2007-10-30 0:00 ` Greg KH
2007-10-30 12:11 ` [PATCH resend] Make the dev_*() family of macros in device.hcomplete Medve Emilian-EMMEDVE1
2007-10-30 15:29 ` Randy Dunlap
2007-10-30 15:40 ` Greg KH
2007-11-01 23:57 ` Andrew Morton
2007-11-02 11:59 ` Medve Emilian-EMMEDVE1
2007-11-02 15:35 ` Greg KH
2007-11-02 15:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193697795-7823-1-git-send-email-Emilian.Medve@Freescale.com \
--to=emilian.medve@freescale.com \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap-open-source@linux.omap.com \
--cc=mac@melware.de \
--cc=mochel@osdl.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®