From: David Woodhouse <dwmw2@infradead.org>
To: "Kirill A. Shutemov" <k.shutemov@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mike Frysinger <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Unexport several headers and cleanup
Date: Tue, 30 Oct 2007 10:25:56 -0400 [thread overview]
Message-ID: <1193754356.2651.7.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20071030135038.GA2429@localhost.localdomain>
On Tue, 2007-10-30 at 15:50 +0200, Kirill A. Shutemov wrote:
> It's bad idea. Taken from directfb:
>
> #if HAVE_ASM_PAGE_H
> #include <asm/page.h>
> #else
> #define PAGE_SIZE sysconf( _SC_PAGESIZE )
> #endif
>
> Other application can use something like this. I think we should drop
> empty headers.
Well, it ought to be using sysconf unconditionally, but I take your
point. I'm happy enough then -- and since it doesn't change the kernel
build it could perhaps even be considered for 2.6.24.
Here you are... make sure you use them in the correct order:
Reviewed-By: David Woodhouse <dwmw2@infradead.org>
Reviewed-By: David Woodhouse <dwmw2@infradead.org>
Reviewed-By: David Woodhouse <dwmw2@infradead.org>
Reviewed-By: David Woodhouse <dwmw2@infradead.org>
--
dwmw2
prev parent reply other threads:[~2007-10-30 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 11:02 Kirill A. Shutemov
2007-10-30 11:02 ` [PATCH 1/4] Unexport asm/page.h Kirill A. Shutemov
2007-10-30 11:02 ` [PATCH 2/4] Unexport asm/elf.h Kirill A. Shutemov
2007-10-30 11:02 ` [PATCH 3/4] Unexport asm/user.h and linux/user.h Kirill A. Shutemov
2007-10-30 11:02 ` [PATCH 4/4] Cleanup asm/{elf,page,user}.h: #ifdef __KERNEL__ is no longer needed Kirill A. Shutemov
2007-10-30 23:50 ` Mike Frysinger
2007-10-30 12:47 ` [PATCH 0/4] Unexport several headers and cleanup David Woodhouse
2007-10-30 13:50 ` Kirill A. Shutemov
2007-10-30 14:25 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193754356.2651.7.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=k.shutemov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®