From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Christoph Hellwig <hch@infradead.org>,
Daniel Walker <dwalker@mvista.com>
Subject: [PATCH] dump_stack on panic
Date: Tue, 30 Oct 2007 20:02:59 -0400 [thread overview]
Message-ID: <1193788979.5623.43.camel@localhost.localdomain> (raw)
Is there any reason why we don't do a dump_stack on panic?
I find this soooo useful in the -rt patch, where Ingo has placed a
dump_stack on panic. With mainline, when I hit a panic, I don't always
know how it got there. So I find myself adding the dump_stack and trying
to create the bug again.
This patch simply adds dump_stack to panic.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/kernel/panic.c b/kernel/panic.c
index 6f6e03e..bd481d7 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -78,6 +78,7 @@ NORET_TYPE void panic(const char * fmt, ...)
vsnprintf(buf, sizeof(buf), fmt, args);
va_end(args);
printk(KERN_EMERG "Kernel panic - not syncing: %s\n",buf);
+ dump_stack();
bust_spinlocks(0);
/*
next reply other threads:[~2007-10-31 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 0:02 Steven Rostedt [this message]
2007-10-31 0:14 ` Andi Kleen
2007-10-31 0:30 ` Steven Rostedt
2007-10-31 8:15 ` Christoph Hellwig
2007-10-31 10:17 ` Ingo Molnar
2007-10-31 10:41 ` Andi Kleen
2007-10-31 10:58 ` Steven Rostedt
2007-10-31 11:17 ` Andi Kleen
2007-10-31 11:39 ` Steven Rostedt
2007-10-31 11:53 ` Andi Kleen
2007-10-31 14:19 ` Arjan van de Ven
2007-10-31 15:00 ` Steven Rostedt
2007-10-31 16:28 ` Arjan van de Ven
2007-10-31 16:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193788979.5623.43.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®