From: David Woodhouse <dwmw2@infradead.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mikael Starvik <mikael.starvik@axis.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/16] CRIS architecture: Correct compile errors
Date: Tue, 06 Nov 2007 08:40:43 +0000 [thread overview]
Message-ID: <1194338443.24746.43.camel@pmac.infradead.org> (raw)
In-Reply-To: <20071030093353.GN11960@axis.com>
On Tue, 2007-10-30 at 10:33 +0100, Jesper Nilsson wrote:
> Add include file with prototype for mtdram_init_device from
> drivers/mtd/devices/mtdram.c.
> Used by axisflashmap.c to boot from ram.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
>
> ---
> mtdram.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> --- /dev/null 2007-10-06 06:38:38.348072750 +0200
> +++ linux-2.6.23/include/linux/mtd/mtdram.h 2002-11-13 15:57:45.000000000 +0100
> @@ -0,0 +1,10 @@
> +#ifndef __MTD_MTDRAM_H__
> +#define __MTD_MTDRAM_H__
> +
> +#ifdef __KERNEL__
> +#include <linux/mtd/mtd.h>
> +int mtdram_init_device(struct mtd_info *mtd, void *mapped_address,
> + unsigned long size, char *name);
> +
> +#endif /* __KERNEL__ */
> +#endif /* __MTD_MTDRAM_H__ */
You don't need #ifdef __KERNEL__ on a file which isn't exported to
userspace. Having removed that, I've applied it to my tree.
--
dwmw2
next prev parent reply other threads:[~2007-11-06 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 9:33 Jesper Nilsson
2007-10-30 12:49 ` David Woodhouse
2007-10-30 13:17 ` Jesper Nilsson
2007-11-06 8:40 ` David Woodhouse [this message]
2007-11-06 9:12 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194338443.24746.43.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®