Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

[Mauro Carvalho Chehab <mchehab@infradead.org>]

> > Seem that something in git-dvb (or mainline) broke this driver:
> > 
> > drivers/media/video/stk11xx-core.c: In function 'show_contrast':
> > drivers/media/video/stk11xx-core.c:707: warning: initialization from incompatible pointer type
> > drivers/media/video/stk11xx-core.c: In function 'show_whitebalance':
> > drivers/media/video/stk11xx-core.c:714: warning: initialization from incompatible pointer type
> > drivers/media/video/stk11xx-core.c: In function 'stk11xx_create_sysfs_file':
> > drivers/media/video/stk11xx-core.c:727: warning: passing argument 1 of 'class_device_create_file' from incompatible pointer type
> > drivers/media/video/stk11xx-core.c: In function 'stk11xx_usb_disconnect':
> > drivers/media/video/stk11xx-core.c:851: warning: passing argument 1 of 'class_device_remove_file' from incompatible pointer type
> > drivers/media/video/stk11xx-core.c:853: warning: passing argument 1 of 'class_device_remove_file' from incompatible pointer type

Those breakages were caused by some changes at sysfs that happened in
mainstream.

> > Also, please ask the v4l/dvb guys to look at this driver - there's not a lot
> > of point in sending it just to me.
> 
> Dvb fellows reviewed it some time ago, but the problem is, that it converts
> one color space to another in kernelspace. We are developping an userspace
> library for drivers such this one, but it takes longer than I expect. Lets
> have it dropped, after the library will be done I'll merge it through v4l tree.

Seems the proper way also to me.

-- 
Cheers,
Mauro