From: David Woodhouse <dwmw2@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-am33-list@redhat.com
Subject: Re: [PATCH 1/2] Suppress A.OUT library support in ELF binfmt if !CONFIG_BINFMT_AOUT [try #3]
Date: Wed, 07 Nov 2007 22:07:00 +0000 [thread overview]
Message-ID: <1194473220.11490.93.camel@pmac.infradead.org> (raw)
In-Reply-To: <20071107174328.31820.62935.stgit@warthog.procyon.org.uk>
On Wed, 2007-11-07 at 17:43 +0000, David Howells wrote:
> --- a/include/linux/a.out.h
> +++ b/include/linux/a.out.h
> @@ -1,6 +1,11 @@
> #ifndef __A_OUT_GNU_H__
> #define __A_OUT_GNU_H__
>
> +#if defined(CONFIG_BINFMT_AOUT) || \
> + defined(CONFIG_BINFMT_AOUT_MODULE) || \
> + defined(CONFIG_IA32_AOUT) || \
> + defined(CONFIG_IA32_AOUT_MODULE)
> +
> #define __GNU_EXEC_MACROS__
>
> #ifndef __STRUCT_EXEC_OVERRIDE__
Ew, no. This is horridly broken. You should never use CONFIG_xxx_MODULE
in the static kernel at all -- and you should _especially_ not be using
it in header files which are exported to userspace.
This abomination certainly doesn't seem to have any direct relation to
mn10300 support -- I think all you really need there is not to attempt
to export {asm,linux}/a.out.h if asm/a.out.h doesn't exist, which is
something you haven't attempted here anyway.
--
dwmw2
next prev parent reply other threads:[~2007-11-07 22:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 17:43 [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel " David Howells
2007-11-07 17:43 ` [PATCH 1/2] Suppress A.OUT library support in ELF binfmt if !CONFIG_BINFMT_AOUT " David Howells
2007-11-07 17:52 ` Mike Frysinger
2007-11-07 22:07 ` David Woodhouse [this message]
2007-11-07 23:30 ` David Howells
2007-11-07 23:54 ` Adrian Bunk
2007-11-08 4:13 ` [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel " Adrian Bunk
2007-11-08 14:00 ` David Howells
2007-11-09 11:02 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194473220.11490.93.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®