From: Stanislav Brabec <utx@penguin.cz>
To: linux-kernel@vger.kernel.org
Cc: Thibaut VARENE <varenet@parisc-linux.org>
Subject: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
Date: Sat, 10 Nov 2007 16:51:15 +0100 [thread overview]
Message-ID: <1194709875.4486.8.camel@utx.utx.cz> (raw)
Attached patch fixes two compilation problems of s1d13xxxfb.c:
- Fixes outdated dbg() message to fix compilation error with debugging enabled.
- Do not read kernel command line options when compiled as module.
Signed-off-by: Stanislav Brabec <utx@penguin.cz>
--- linux-2.6.23/drivers/video/s1d13xxxfb.c 2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23/drivers/video/s1d13xxxfb.c 2007-11-02 16:48:34.000000000 +0100
@@ -540,7 +540,7 @@
int ret = 0;
u8 revision;
- dbg("probe called: device is %p\n", dev);
+ dbg("probe called: device is %p\n", pdev);
printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
@@ -753,8 +753,11 @@
static int __init
s1d13xxxfb_init(void)
{
+
+#ifndef MODULE
if (fb_get_options("s1d13xxxfb", NULL))
return -ENODEV;
+#endif
return platform_driver_register(&s1d13xxxfb_driver);
}
________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx
next reply other threads:[~2007-11-10 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 15:51 Stanislav Brabec [this message]
2007-11-10 23:29 ` dave chung
2007-11-11 15:17 ` Thibaut VARENE
2007-11-13 23:21 ` Kristoffer Ericson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194709875.4486.8.camel@utx.utx.cz \
--to=utx@penguin.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=varenet@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®