From: Bart Van Assche <bvanassche@acm.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
alim.akhtar@samsung.com, avri.altman@wdc.com,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bao D . Nguyen" <quic_nguyenb@quicinc.com>
Subject: Re: [PATCH] scsi: ufs: core: Set default runtime/system PM levels before ufshcd_hba_init()
Date: Wed, 19 Feb 2025 12:36:19 -0800 [thread overview]
Message-ID: <1194feaa-ea58-42cb-96fd-8bfd348d9589@acm.org> (raw)
In-Reply-To: <20250219105047.49932-1-manivannan.sadhasivam@linaro.org>
On 2/19/25 2:50 AM, Manivannan Sadhasivam wrote:
> Commit bb9850704c04 ("scsi: ufs: core: Honor runtime/system PM levels if
> set by host controller drivers") introduced the check for setting default
> PM levels only if the levels are uninitialized by the host controller
> drivers. But it missed the fact that the levels could initialized to 0
> (UFS_PM_LVL_0) on purpose by the controller drivers. Even though none of
> the drivers are doing so now, the logic should be fixed irrespectively.
>
> So set the default levels unconditionally before calling ufshcd_hba_init()
> API which initializes the controller drivers. It ensures that the
> controller drivers could override the default levels if required.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2025-02-19 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 10:50 Manivannan Sadhasivam
2025-02-19 20:36 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194feaa-ea58-42cb-96fd-8bfd348d9589@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®