From: Eric Paris <eparis@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: linux-kernel@vger.kernel.org, sds@tycho.nsa.gov,
selinux@tycho.nsa.gov, alan@redhat.com, chrisw@redhat.com,
hpa@zytor.com, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3] mmap: round mmap hint address above mmap_min_addr
Date: Fri, 16 Nov 2007 16:49:53 -0500 [thread overview]
Message-ID: <1195249793.2924.99.camel@localhost.localdomain> (raw)
In-Reply-To: <Xine.LNX.4.64.0711170841200.22208@us.intercode.com.au>
On Sat, 2007-11-17 at 08:42 +1100, James Morris wrote:
> On Fri, 16 Nov 2007, Eric Paris wrote:
>
> > +#ifdef CONFIG_SECURITY
> > + /*
> > + * If a hint addr is less than mmap_min_addr change addr to be as
> > + * low as possible but still greater than mmap_min_addr
> > + */
> > + if (!(flags & MAP_FIXED) && ((void *)addr != NULL) &&
> > + (addr < mmap_min_addr))
> > + addr = PAGE_ALIGN(mmap_min_addr);
> > +#endif
>
> Please make this a static inline which is optimized away with
> !CONFIG_SECURITY.
Where do you think these should go? You think I should instead have a
static inline function in both mmap.c and nommu.c so the CONFIG check
isn't scattered in this code but still in this file? Or did you
actually want something in security.h so I only have the code once?
-Eric
next prev parent reply other threads:[~2007-11-16 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 20:54 Eric Paris
2007-11-16 21:42 ` James Morris
2007-11-16 21:49 ` Eric Paris [this message]
2007-11-16 21:55 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195249793.2924.99.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=chrisw@redhat.com \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®