From: David Woodhouse <dwmw2@infradead.org>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
Bryan Wu <bryan.wu@analog.com>,
Bryan Wu <cooloney.lkml@gmail.com>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH 1/1] [MTD/NAND]: Add Blackfin BF52x on-chip NAND Flash controller driver support in bf5xx_nand driver
Date: Sat, 24 Nov 2007 06:43:28 +0000 [thread overview]
Message-ID: <1195886608.25590.59.camel@pmac.infradead.org> (raw)
In-Reply-To: <200711231704.59948.rgetz@blackfin.uclinux.org>
On Fri, 2007-11-23 at 17:04 -0500, Robin Getz wrote:
> It could be a runtime if() but we don't currently have the is_mach() all set
> up properly today.
>
> This is because on most systems that Blackfin ships on - memory is the
> dominate cost of the system, and end users don't want to take the either the
> storage (flash) hit of having code they don't use, or the run time (DRAM)
> overhead. They are fine with compiling 2 kernels for two platforms if it
> means things are cheaper. :)
>
> That being said, we still need to go back, and add things properly - and just
> let gcc optimise things away if it is not used - c code is more maintainable
> than all the ifdefs we have today.
>
> This is the goal - it will just take a little bit to get there.
For now I suspect you could at least define machine_is_bf52x() and
machine_is_bf54x() which are hard-coded to either zero or one according
to the configuration, and at least you wouldn't need to add ifdefs to
drivers.
--
dwmw2
next prev parent reply other threads:[~2007-11-24 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 10:14 Bryan Wu
2007-11-23 10:19 ` David Woodhouse
2007-11-23 14:25 ` Bryan Wu
2007-11-23 21:52 ` Arjan van de Ven
2007-11-23 22:04 ` Robin Getz
2007-11-24 6:43 ` David Woodhouse [this message]
2007-11-24 7:15 ` Bryan Wu
2007-11-24 13:11 ` Robin Getz
-- strict thread matches above, loose matches on Subject: below --
2007-10-30 9:08 Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195886608.25590.59.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=arjan@infradead.org \
--cc=bryan.wu@analog.com \
--cc=cooloney.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael.hennerich@analog.com \
--cc=rgetz@blackfin.uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®