mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: "Adrian Bunk" <bunk@kernel.org>,
	"Toralf Förster" <toralf.foerster@gmx.de>,
	v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org,
	video4linux-list@redhat.com
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] drivers/media/Makefile: always enter video/
Date: Thu, 13 Dec 2007 07:55:56 -0200	[thread overview]
Message-ID: <1197539756.4729.15.camel@gaivota> (raw)
In-Reply-To: <Pine.LNX.4.58.0712121310330.111@shell2.speakeasy.net>


Em Qua, 2007-12-12 às 13:13 -0800, Trent Piepho escreveu:
> On Wed, 12 Dec 2007, Adrian Bunk wrote:
> > >
> > > I don't see any issue on making both dependent on VIDEO_TUNER for
> > > 2.6.24, since they are currently used only by tuner core module
> > > (tuner.ko).
> > >...
> >
> > If "selected code isn't included" also counts as a bug at least dabusb
> > is also affected by the same bug.
> 
> > What about the patch below instead that fixes the actual bug instead of
> > working around it?
> 
> Pretty much exactly the same as the patch I posted on Oct 19th.  Some
> people like to make things harder than they need to be.
> 
> http://article.gmane.org/gmane.comp.video.video4linux/35274

I'm applying Adrian's patch. All code under radio/ depends on VIDEO_DEV.

I don't like this approach, since it doesn't seem to be a good idea
force all kernel compilations to look under all the +200 drivers
under /media. Yet, better to slow down the compilation than to broke it.

To me, the proper solution is to move the code that can be used by
either DVB or V4L to a common place, and making the common place
dependent of VIDEO_DEV | DVB_CORE. Seems to late at -rc cycle for doing
this.

-- 
Cheers,
Mauro


      parent reply	other threads:[~2007-12-13  9:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-12  8:34 build #340 failed for 2.6.24-rc5-g75b8c13 in linux/drivers/media/video/tuner.ko Toralf Förster
2007-12-12 13:42 ` [v4l-dvb-maintainer] " Michael Krufky
2007-12-12 14:46   ` Mauro Carvalho Chehab
2007-12-12 16:00     ` mkrufky
2007-12-12 17:57       ` [v4l-dvb-maintainer] build #340 failed for 2.6.24-rc5-g75b8c13 in?linux/drivers/media/video/tuner.ko Adrian Bunk
2007-12-13 20:11         ` Mauro Carvalho Chehab
2007-12-12 18:40     ` [2.6 patch] drivers/media/Makefile: always enter video/ Adrian Bunk
2007-12-12 21:13       ` [v4l-dvb-maintainer] " Trent Piepho
2007-12-12 21:16         ` [v4l-dvb-maintainer] [2.6 patch] drivers/media/Makefile: alwa ys " mkrufky
2007-12-13  9:55         ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197539756.4729.15.camel@gaivota \
    --to=mchehab@infradead.org \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®