From: Shaohua Li <shaohua.li@intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, mel <mel@csn.ul.ie>
Subject: [RFC]handle error of rmqueue_bulk
Date: Fri, 14 Dec 2007 17:08:57 +0800 [thread overview]
Message-ID: <1197623337.3732.1.camel@sli10-desk.sh.intel.com> (raw)
if rmqueue_bulk fails, we might get page with wrong migratetype,
shouldn't we consider the case?
Thanks,
Shaohua
Index: linux/mm/page_alloc.c
===================================================================
--- linux.orig/mm/page_alloc.c 2007-12-14 16:44:35.000000000 +0800
+++ linux/mm/page_alloc.c 2007-12-14 16:45:42.000000000 +0800
@@ -1067,8 +1067,12 @@ again:
/* Allocate more to the pcp list if necessary */
if (unlikely(&page->lru == &pcp->list)) {
- pcp->count += rmqueue_bulk(zone, 0,
+ int cn;
+ cn = rmqueue_bulk(zone, 0,
pcp->batch, &pcp->list, migratetype);
+ if (unlikely(!cn))
+ goto failed;
+ pcp->count += cn;
page = list_entry(pcp->list.next, struct page, lru);
}
next reply other threads:[~2007-12-14 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 9:08 Shaohua Li [this message]
2007-12-14 11:53 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197623337.3732.1.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®