From: Joe Perches <joe@perches.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-2.6.25 1/8] Create ipv4_is_<type>(__be32 addr) functions
Date: Mon, 17 Dec 2007 14:42:41 -0800 [thread overview]
Message-ID: <1197931361.27386.67.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0712172333550.32270@fbirervta.pbzchgretzou.qr>
On Mon, 2007-12-17 at 23:37 +0100, Jan Engelhardt wrote:
> >+static inline bool ipv4_is_loopback(__be32 addr)
> >+{
> >+ return (addr & htonl(0xff000000)) == htonl(0x7f000000);
> >+}
> >+
> Can we use __constant_htonl()?
I believe the generated code is the same.
> >+static inline bool ipv4_is_private_10(__be32 addr)
> >+{
> >+ return (addr & htonl(0xff000000)) == htonl(0x0a000000);
> >+}
>
> What are these functions needed for, even? There does not seem to be
> any code (at least in davem's net-2.6.25:net/ipv4/, where I dared to grep)
> that uses them.
include/net/addrconf.h
net/sctp/protocol.c
cheers, Joe
next prev parent reply other threads:[~2007-12-17 22:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e2ebcbf24539c0a3ef2ac77147dbfa55d8ac9e33.1197432867.git.joe@perches.com>
2007-12-13 23:38 ` Joe Perches
[not found] ` <1197589141-7020-2-git-send-email-joe@perches.com>
[not found] ` <1197589141-7020-3-git-send-email-joe@perches.com>
[not found] ` <1197589141-7020-4-git-send-email-joe@perches.com>
[not found] ` <1197589141-7020-5-git-send-email-joe@perches.com>
[not found] ` <1197589141-7020-6-git-send-email-joe@perches.com>
2007-12-16 21:42 ` David Miller
2007-12-17 22:37 ` Jan Engelhardt
2007-12-17 22:41 ` David Miller
2007-12-17 22:42 ` Joe Perches [this message]
2007-12-17 22:43 ` David Miller
2007-12-17 23:02 ` Jan Engelhardt
[not found] ` <885ea24008e2b1c07e6bff0344f260a0ff104a35.1197432867.git.joe@perches.com>
2007-12-13 23:39 ` [PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros Joe Perches
2007-12-16 21:48 ` David Miller
2007-12-17 4:01 ` Joe Perches
2007-12-17 4:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197931361.27386.67.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®