From: Johannes Berg <johannes@sipsolutions.net>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mattias Nissler <mattias.nissler@gmx.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/8] debugfs: allow access to signed values
Date: Wed, 19 Dec 2007 17:00:34 +0100 [thread overview]
Message-ID: <1198080034.4747.15.camel@johannes.berg> (raw)
In-Reply-To: <20071219012739.6dcdd150@morte> (sfid-20071219_003309_142235_6F2FB382)
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
> +static u64 debugfs_s8_get(void *data)
> struct simple_attr {
> - u64 (*get)(void *);
> + unsigned long long (*get)(void *);
That seems wrong. Wouldn't you have to declare all the _get functions
with unsigned long long too now to avoid trouble on systems where u64 !=
unsigned long long?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-12-19 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071219001955.055692620@polimi.it>
2007-12-19 0:27 ` Stefano Brivio
2007-12-19 6:45 ` Greg KH
2007-12-19 9:20 ` Stefano Brivio
2007-12-19 14:29 ` John W. Linville
2007-12-19 9:28 ` [PATCH v4 " Stefano Brivio
2007-12-19 16:00 ` Johannes Berg [this message]
2007-12-20 12:15 ` Stefano Brivio
2007-12-20 12:47 ` Arnd Bergmann
2007-12-28 18:58 ` Christoph Hellwig
2007-12-28 19:15 ` Johannes Berg
2007-12-29 18:20 ` Stefano Brivio
2007-12-20 12:40 ` [PATCH v5 " Stefano Brivio
2007-12-20 14:34 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198080034.4747.15.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mattias.nissler@gmx.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®