mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Dillow <dillowda@ornl.gov>
To: Roland Dreier <rdreier@cisco.com>
Cc: torvalds@linux-foundation.org, general@lists.openfabrics.org,
	linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] please pull infiniband.git for-linus
Date: Thu, 03 Jan 2008 15:13:07 -0500	[thread overview]
Message-ID: <1199391187.7561.38.camel@lap75545.ornl.gov> (raw)
In-Reply-To: <adafxxeu495.fsf@cisco.com>


On Thu, 2008-01-03 at 10:56 -0800, Roland Dreier wrote:
> > If we've got time before 2.6.24 final, I'd wait on this a bit.
>  > ib_srp:srp_remove_work() has them reversed as well, and I'm currently
>  > tracking down why it oopses when the srp_remove_host() happens before
>  > the scsi_remove_host(), which is the documented call sequence.
> 
> I think the best thing to do is to merge this (assuming that Linus
> gets to it), since it looks quite safe and definitely fixes a crash.
> Then if we get to the root cause we can change the order of the calls
> if it turns out a different fix is required.

I've made progress on the root cause (posted in another thread), but we
need to fix ib_srp.c:srp_remove_work() as well, as I think it will have
the same issue. It will only be hit if we cannot reconnect to the
target, so it probably doesn't see a lot of use.

I'll send a new patch to you for just the ib_srp.c side.
Dave


  reply	other threads:[~2008-01-03 20:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03 18:29 Roland Dreier
2008-01-03 18:39 ` David Dillow
2008-01-03 18:56   ` Roland Dreier
2008-01-03 20:13     ` David Dillow [this message]
2008-01-03 20:20       ` David Dillow
2008-01-03 21:34         ` Roland Dreier
2008-01-03 23:11         ` Rik van Riel
2008-01-03 23:18           ` Dave Dillow
  -- strict thread matches above, loose matches on Subject: below --
2007-10-13 21:17 Roland Dreier
2007-10-12  1:08 Roland Dreier
2007-10-12  1:17 ` David Miller
2007-10-12  2:58   ` Linus Torvalds
2007-10-12  3:28     ` David Miller
2007-10-12  3:52     ` Greg KH
2007-10-12  4:03       ` Linus Torvalds
2007-10-12 12:58     ` Jeff Garzik
2007-10-13  1:10   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199391187.7561.38.camel@lap75545.ornl.gov \
    --to=dillowda@ornl.gov \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®