mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Phil Endecott" <phil_wueww_endecott@chezphil.org>
To: "Andreas Schwab" <schwab@suse.de>
Cc: "Jiri Slaby" <jirislaby@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	"Frederik Deweerdt" <deweerdt@free.fr>
Subject: Re: strace, accept(), ERESTARTSYS and EINTR
Date: Sat, 05 Jan 2008 18:18:25 +0000	[thread overview]
Message-ID: <1199557105493@dmwebmail.japan.chezphil.org> (raw)
In-Reply-To: <jed4sgjkhh.fsf@sykes.suse.de>

Andreas Schwab wrote:
> "Phil Endecott" <phil_wueww_endecott@chezphil.org> writes:
>
>> However, there's a lot of code and I know that there are bugs in it.  I
>> just want to focus on the kernel-related issue that the strace fragment
>> that I posted brings up:  even if my user code gets completely screwed up
>> (corrupts its stack, runs out of FDs/VM/threads etc), I don't think that I
>> should see in the strace output that accept() has returned
>> ERESTARTSYS.
>
> strace always sees the raw return value, before the signal handler is
> executed and before the check for syscall restart is done.

Yes, but I should see the real final return value in another strace 
output line before I see that thread doing something else.  Correct?  
Here's the strace output again.  Look at what thread 11079 does:

[pid 11079] accept(3,  <unfinished ...>
[pid 11093] restart_syscall(<... resuming interrupted call ...>
<unfinished ...>
[pid  8799] --- SIGSTOP (Stopped (signal)) @ 0 (0) ---
[pid 11079] <... accept resumed> 0xbfdaa73c, [16]) = ? ERESTARTSYS (To
be restarted)
[pid  8799] read(6,  <unfinished ...>
[pid 11079] fcntl64(-512, F_SETFD, FD_CLOEXEC) = -1 EBADF (Bad file descriptor)

strace reports accept() returning ERESTARTSYS, and the next thing we 
see from that thread is the call to fcntl(), which is the next thing 
that my code does.

Phil.





  reply	other threads:[~2008-01-05 18:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-04 21:01 Phil Endecott
2008-01-04 22:55 ` Jiri Slaby
2008-01-04 23:52   ` Phil Endecott
2008-01-05  1:06 ` Frederik Deweerdt
2008-01-05  1:38   ` Phil Endecott
2008-01-05 10:31     ` Jiri Slaby
2008-01-05 11:33       ` Jiri Slaby
2008-01-05 14:24         ` Phil Endecott
2008-01-05 16:38           ` Andreas Schwab
2008-01-05 18:18             ` Phil Endecott [this message]
2008-01-05 19:19               ` Andreas Schwab
2008-01-05 19:35                 ` Phil Endecott
2008-01-05 19:50                   ` Andreas Schwab
2008-01-05 15:03 ` Andi Kleen
2008-01-05 17:02   ` Jiri Slaby
2008-01-05 18:42   ` Phil Endecott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199557105493@dmwebmail.japan.chezphil.org \
    --to=phil_wueww_endecott@chezphil.org \
    --cc=deweerdt@free.fr \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®