From: David Woodhouse <dwmw2@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
heiko.carstens@de.ibm.com, olof@lixom.net, mingo@elte.hu,
mpm@selenic.com
Subject: Re: [patch 3/5] Add the end-of-trace marker and the module list to WARN_ON()
Date: Sun, 06 Jan 2008 10:04:06 +0000 [thread overview]
Message-ID: <1199613846.4111.325.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20080105191044.23712dc7@laptopd505.fenrus.org>
On Sat, 2008-01-05 at 19:10 -0800, Arjan van de Ven wrote:
> Another issue is that, unlike oopses, WARN_ON() doesn't currently
> printk the helpful "cut here" line,
I'd rather see the 'cut here' line disappear altogether. Often, the
line(s) which come immediately before it are extremely relevant to the
problem. Cutting them is bad.
--
dwmw2
next prev parent reply other threads:[~2008-01-06 10:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 3:07 [patch 0/5] enhance WARN_ON series Arjan van de Ven
2008-01-06 3:08 ` [patch 1/5] Introduce __WARN() Arjan van de Ven
2008-01-06 11:44 ` Richard Knutsson
2008-01-06 15:42 ` Arjan van de Ven
2008-01-06 16:09 ` Richard Knutsson
2008-01-06 17:10 ` Arjan van de Ven
2008-01-06 17:42 ` Richard Knutsson
2008-01-06 3:09 ` [patch 2/5] move WARN_ON() out of line Arjan van de Ven
2008-01-06 19:40 ` Olof Johansson
2008-01-06 3:10 ` [patch 3/5] Add the end-of-trace marker and the module list to WARN_ON() Arjan van de Ven
2008-01-06 10:04 ` David Woodhouse [this message]
2008-01-07 17:31 ` Valdis.Kletnieks
2008-01-06 3:11 ` [patch 4/5] bugh-remove-have_arch_bug--have_arch_warn Arjan van de Ven
2008-01-06 3:12 ` [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON Arjan van de Ven
2008-01-06 11:16 ` Benjamin Herrenschmidt
2008-01-06 14:46 ` Olof Johansson
2008-01-06 9:26 ` [patch 0/5] enhance WARN_ON series Ingo Molnar
2008-01-06 20:22 ` [PATCH] Add bug/warn marker to generic report_bug() Olof Johansson
2008-01-06 21:38 ` Arjan van de Ven
2008-01-07 1:22 ` Olof Johansson
2008-01-07 4:55 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199613846.4111.325.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®