From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: megaraidlinux@lsi.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH][SCSI] megaraid: Convert from "scsi.h" to <scsi.h> (and friends)
Date: Sun, 06 Jan 2008 13:31:03 -0600 [thread overview]
Message-ID: <1199647863.5205.85.camel@localhost.localdomain> (raw)
In-Reply-To: <20080106190335.28212.90140.sendpatchset@thinktank.campus.ltu.se>
On Sun, 2008-01-06 at 20:03 +0100, Richard Knutsson wrote:
> Convert glue-include "scsi.h" to <scsi.h> (and friends).
>
> (binary sizes)
> allyesconfig: before: 260132
> after: 260048
>
> allmodconfig: before: 261740
> after: 261656
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Do not have the hardware, but since it compiles I hope it is alright.
>
>
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index 66c6520..9f1e2c5 100644
> --- a/drivers/scsi/megaraid.c
> +++ b/drivers/scsi/megaraid.c
> @@ -48,8 +48,9 @@
> #include <linux/dma-mapping.h>
> #include <scsi/scsicam.h>
>
> -#include "scsi.h"
> +#include <scsi/scsi_cmnd.h>
> #include <scsi/scsi_host.h>
> +#include <scsi.h>
I'm afraid this is pretty much wrong. The scsi.h being referred to here
is the local scsi.h in the build directory, so it should be included as
a string. For #include, "..." means begin the search in the local
directory (what is wanted here) and <...> means begin the search
starting with the predefined include paths.
The rest of the patch looks like a spurious (unrelated and undescribed)
downcasing of TRUE and FALSE.
James
next prev parent reply other threads:[~2008-01-06 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 19:03 Richard Knutsson
2008-01-06 19:31 ` James Bottomley [this message]
2008-01-06 21:10 ` ricknu-0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199647863.5205.85.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux@lsi.com \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®