From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751990AbcFWVOK (ORCPT ); Thu, 23 Jun 2016 17:14:10 -0400 Received: from mga11.intel.com ([192.55.52.93]:35160 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbcFWVOI (ORCPT ); Thu, 23 Jun 2016 17:14:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,518,1459839600"; d="scan'208";a="1004056210" Subject: Re: [patch] cpufreq/pcc-cpufreq: Fix doorbell.access_width To: Mike Galbraith References: <1466579229.3188.14.camel@gmail.com> <1466664342.5839.39.camel@gmail.com> Cc: Lv Zheng , Bob Moore , LKML , Linux PM , Linux ACPI From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: <119a72eb-b691-77cf-9d3a-55b67a50f410@intel.com> Date: Thu, 23 Jun 2016 23:13:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1466664342.5839.39.camel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/2016 8:45 AM, Mike Galbraith wrote: > Commit 920de6ebfab8 apparently exposed a latent bug, doorbell.access_width > is initialized to 64, but per Lv Zheng, it should be 4, and indeed, making > that change does bring pcc-cpufreq back to life. > > Suggested-by: Lv Zheng > Signed-off-by: Mike Galbraith > --- > drivers/cpufreq/pcc-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/cpufreq/pcc-cpufreq.c > +++ b/drivers/cpufreq/pcc-cpufreq.c > @@ -487,7 +487,7 @@ static int __init pcc_cpufreq_probe(void > doorbell.space_id = reg_resource->space_id; > doorbell.bit_width = reg_resource->bit_width; > doorbell.bit_offset = reg_resource->bit_offset; > - doorbell.access_width = 64; > + doorbell.access_width = 4; > doorbell.address = reg_resource->address; > > pr_debug("probe: doorbell: space_id is %d, bit_width is %d, " OK, I picked this up from the LKML patchwork (will push to Linus tomorrow), but next time please CC patches related to ACPI to linux-acpi and PM patches to linux-pm (so this one should have gone to both, ideally). They are much easier to handle/review then and more people are likely to look at them too. Thanks, Rafael