From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BD47258CDB for ; Wed, 21 May 2025 15:58:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747843129; cv=none; b=OntdDbaTEvQG/Nh/30Wuquo3jHASWkzhNrfgzyEWpZpFfz6lGHMN6mxmhxJAbkeXD1Uk10XpZy3nMyAjxA+lP2sBdg0yywo1Cy+cSSCoKB13vj54N4ORcqXCQ5Uu7RshijydAg1jsCJYL1pktjoXpv3RwTppCD/PTGJgsZycrp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747843129; c=relaxed/simple; bh=I9VBBxVFYOrWsTK7GjRldDLctXPPzg+fbuHoTp+4SCk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eeiXsy7nQ0ifIaDnTvE9AkTYtlIzzEhFiKCUDCi0f0tIhE2/MQNrqI2hlblxYLtkb3YW2OLA5bdtkoZtLVYec9ep6KDQ16BpQEYxOvo/qaiGDiz4RusAk2Je1PN4IP41b/+vFDRamI4INFngRtSBVkTiauhVBSSJCNb+vwHgUUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h6hrAbYx; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h6hrAbYx" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-43edb40f357so58497555e9.0 for ; Wed, 21 May 2025 08:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1747843124; x=1748447924; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7jGMaRN9DTvk91Wh6QyGZY6sK/KJmkltlvMirfVWYJg=; b=h6hrAbYxPLcQy8VKLANuehUMWTeH3kchwwt/Ziv7rjzpaLz/DEp8cQE8torhel0Qvz Ob1lje5u0MZG/Uw7QWb/IaH2BnyuIhzYiAAa3KvUlOd53MAlb7Crxa5NiWPrWfhz8MUP GsPJoBEIDSFZDw0uziIZPzR7g17niLjHxy7Q7ns/mRQhdTXW9ZlO8ELHny+RkGDpW3jw u5gLLJ47LnDjKF2gEUwQQr+GE4wWUNxrmo+uXn9zZGoDcJrbwziJPsqLeqINhhuwZOL+ gxGqYOY93xiGMP43iLx6MMCW9dfG21kiiISGi19UXE5jXQzbUkx0xVAIH+pXLOhkAHkz WPpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747843124; x=1748447924; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7jGMaRN9DTvk91Wh6QyGZY6sK/KJmkltlvMirfVWYJg=; b=jiWtP5/HuI05s7UZlOGWDuHkLlB+qpBaKBHe34icq2caKPOBOwJQxlriZDFTtGpHwo lmXHfJm6a/q2sZFrsrqkEVKe+TMisjqkIDEhB6uDsQouWcmpFYI28rUNgVJEEGLEQZmx PjTdJaILDN96JltGy00s9gXO403n+gpv3KUkF23GnmvU74p5ZODEA+HU5DeVV3sUaRMm OAeiJfbeoNa2ZL6NcRi2RwBKnZIxlLa4GUofjOHWdLd2WCHKgxETvcMliBmQWdDH2yo4 u7A0HK5UPnSjI0PaamVejcow+YYjfRiBxGYnxKOQCVEOSClXjgl/9twSFEbErOKo2NyA HV3A== X-Forwarded-Encrypted: i=1; AJvYcCXnSXDzqbKllvfF1ipgoI7tNqOniC7YL9VLkiR/FRWh4TfTQ5WO1s6+iTMldmavIwwYG+6AGueFhGJSkpA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyfu4PPLEJFCB4DLCsLbPFM9TlcIP75b2OcA6U69TUGPzh+cRCc H5w2u0iKk0krW7Yc/OHhcW2DTtqRmxzIqvMPLYGShle+yW3I/5LbWhhDcHqF7Jx6QnQ= X-Gm-Gg: ASbGncu5IDI0+r1LwA+V8O3NQ2s575RvioeEFbmNYX6fWXCmyxbA72voYiF7TXcvPiY ab70jk46ur0oHRCeZBchmlUXC8DJB75uzfNHvEiVG1x9bhQywjtm+bddjvx+CYjSFUfPPUr6Qmk ODRH0/TzaoYfg9aqnx5LCgPDUNtJ/SW9kfel8DSJoxEkmdtDrBMadj53seEu3N7We2ZHC8NUz+F ymmUX+T4lFcP4JvgZQY8pRgxLWKyIwVzjfwrnFLNkqXVsXEGSUIikHqRl1AiMyw4HvektPKBZtk ml3q2d9nbJAk5NvMXPsx1hZFh6mM3LrsF6IRDINBE1d2oGyuBOPC2+R4WOFs2Aa8fOY= X-Google-Smtp-Source: AGHT+IE94Qc/sbvf18GBZCQv3ZQ8s8ZqdtBvtnfrv3gSKGcbnewhx8YlU5QP8S7QSIUDnlJDrBopzQ== X-Received: by 2002:a05:600c:34c4:b0:43c:ee62:33f5 with SMTP id 5b1f17b1804b1-442fd6752e7mr217340645e9.27.1747843124389; Wed, 21 May 2025 08:58:44 -0700 (PDT) Received: from [192.168.1.3] ([37.18.136.128]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a35ca4d2ddsm19933864f8f.7.2025.05.21.08.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 08:58:44 -0700 (PDT) Message-ID: <119c9a70-6ea8-46f0-b877-8a433d97ce84@linaro.org> Date: Wed, 21 May 2025 16:58:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v21 4/4] perf: arm_pmuv3: Add support for the Branch Record Buffer Extension (BRBE) To: Rob Herring , Will Deacon Cc: Mark Rutland , Catalin Marinas , Jonathan Corbet , Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Anshuman Khandual , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev References: <20250407-arm-brbe-v19-v21-0-ff187ff6c928@kernel.org> <20250407-arm-brbe-v19-v21-4-ff187ff6c928@kernel.org> <20250519150621.GA17177@willie-the-truck> <20250519215651.GB2650608-robh@kernel.org> Content-Language: en-US From: James Clark In-Reply-To: <20250519215651.GB2650608-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 19/05/2025 10:56 pm, Rob Herring wrote: > On Mon, May 19, 2025 at 04:06:22PM +0100, Will Deacon wrote: >> Hey Rob, >> >> On Mon, Apr 07, 2025 at 12:41:33PM -0500, Rob Herring (Arm) wrote: >>> From: Anshuman Khandual >>> >>> The ARMv9.2 architecture introduces the optional Branch Record Buffer >>> Extension (BRBE), which records information about branches as they are >>> executed into set of branch record registers. BRBE is similar to x86's >>> Last Branch Record (LBR) and PowerPC's Branch History Rolling Buffer >>> (BHRB). >> >> Since you picked this up from v19, the driver has changed considerably >> and I presume you will be continuing to extend it in future as the >> architecture progresses. Perhaps having you listed as Author (and >> crucially, in git blame :p) with Anshuman as a Co-developed-by: would be >> more appropriate? > > Shrug. > >>> --- >>> drivers/perf/Kconfig | 11 + >>> drivers/perf/Makefile | 1 + >>> drivers/perf/arm_brbe.c | 802 +++++++++++++++++++++++++++++++++++++++++++ >>> drivers/perf/arm_brbe.h | 47 +++ >>> drivers/perf/arm_pmu.c | 15 +- >>> drivers/perf/arm_pmuv3.c | 129 ++++++- >>> include/linux/perf/arm_pmu.h | 8 + >>> 7 files changed, 1006 insertions(+), 7 deletions(-) >> >> Do you know if James Clark's tests [1] are going to be respun for the >> perf tool? It would be handy to have some way to test this new >> functionality. > > Yes. I dropped them here because I've been told by Arnaldo in the past > to send userspace stuff separately. > That version of the test was out of date so I've pushed the new version here: https://git.linaro.org/plugins/gitiles/people/james.clark/linux.git/+/16e4a18c2d5fc53736f05c9052b1d11d74909707 But I'll wait for the driver changes to be finalised before posting it. Or Rob can take it back into the patchset.