From: Michael Guntsche <mike@it-loops.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: BUG: scheduling while atomic
Date: Mon, 6 Jul 2009 17:28:06 +0200 [thread overview]
Message-ID: <11EC5046-5F30-4CB6-BDAF-0DAA2C69929B@it-loops.com> (raw)
In-Reply-To: <20090706083119.GA17782@gondor.apana.org.au>
On Jul 6, 2009, at 10:31, Herbert Xu wrote:
> On Mon, Jul 06, 2009 at 03:43:33PM +0800, Herbert Xu wrote:
>>
>> I think the first backtrace is bogus, this is where the real
>> problem is. So what see here is that on xmit from the network,
>> PPP will call pty_write from BH context which eventually leads
>> to tty_throttle and the sleep.
>
> Here's the stupidest possible fix for this, changing the mutex
> to a spin lock. We should also revert the other commit that
> tried to fix this, a6540f731d506d9e82444cf0020e716613d4c46c as
> those unthrottles are really needed
<snip>
Just to confirm.
I reverted the commit and applied the patch on-top of 2.6.31-rc2.
Up to now I was not able to reproduce the crashes I had before on my
setup here.
Kind regards,
Michael
next prev parent reply other threads:[~2009-07-06 15:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 11:10 Michael Guntsche
2009-06-27 13:06 ` Alan Cox
2009-06-27 16:07 ` Michael Guntsche
2009-07-06 7:43 ` Herbert Xu
2009-07-06 8:31 ` Herbert Xu
2009-07-06 15:28 ` Michael Guntsche [this message]
2009-07-06 15:32 ` Alan Cox
2009-07-06 17:17 ` Alan Cox
2009-07-06 18:07 ` Michael Guntsche
2009-07-06 18:18 ` Alan Cox
2009-07-06 18:37 ` Michael Guntsche
2009-07-06 10:00 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2012-02-13 8:08 Florian Tobias Schandinat
2010-08-27 7:59 Sergey Senozhatsky
2010-08-27 19:02 ` Rafael J. Wysocki
2010-08-28 6:42 ` Pavel Machek
2010-08-30 7:29 ` Sergey Senozhatsky
2010-08-30 10:04 ` Sergey Senozhatsky
2009-06-19 18:15 Sergey Senozhatsky
2009-06-20 17:43 ` Rabin Vincent
2009-06-20 18:54 ` Sergey Senozhatsky
2009-06-22 9:04 ` Alan Cox
2009-06-22 9:57 ` Alan Cox
2009-06-22 11:33 ` Sergey Senozhatsky
2009-06-22 12:36 ` Alan Cox
2009-06-22 13:59 ` Sergey Senozhatsky
2009-07-06 7:55 ` Herbert Xu
2006-12-08 15:47 Christian
2006-06-02 9:39 fonseka
2006-06-02 12:37 ` Roger Luethi
2006-06-02 14:07 ` fonseka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11EC5046-5F30-4CB6-BDAF-0DAA2C69929B@it-loops.com \
--to=mike@it-loops.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®