From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E4951BDAB5 for ; Thu, 23 Jan 2025 23:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737676613; cv=none; b=HRFC/9mkR6nOzKDluDE5TmLL5na+vvSIPXTAWeSEeZQWxV/YoALazN9JcVehniPuQenGHHtI999wnLKmZTrvgmXRF5GTt0mjFxwq3X5pmUm+3nR8AHSBq3d9BLt+gWwgpVVcmJvS9rhgCj3NxSMR8mSgYZ5KOHeYERylL5hpBFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737676613; c=relaxed/simple; bh=W9JJqzoLbJ2w9vRz5mOhVtHHCstDEKCjW81MCNLFexw=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=U96TDLc0N3/S4jcEe7Ktp7kj4+Trph8CBzqT8BVdjjHfD/zYSJ76BpHHAG5YVfc9rKa1rJInrFvBLL9hvpIWC89DCE99fHWhtXgOR5yVUwjvrHth4fU7KfN1tBZhoyUq7FMb1I8GxKGiSmiOyjlHV2EvGw53d2CbVqRrRsMAJRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BMuauh09; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BMuauh09" Message-ID: <11b81c8b-5ef1-470c-836a-a436ecadf0f4@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737676594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nKnjB9QFtA5GWFQs3FvapprWdMQNbXukoRejQDs+ZtA=; b=BMuauh09Hah9j32wLPh8Uc9gIYcPh7uft6ysJVcYGJQE1XqW7FREugCabFu3MVWHK8Jipy HROYK1a2b0T4NyZ/Cd1ECDmUPICsf1zpRCmHYfqyqUh7OZoSCTheJWqIonXfv0i5IVhh+R sDqWwoatdZG2QNpOmyPa1TZW10vCAM4= Date: Thu, 23 Jan 2025 18:56:29 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH next] drm: zynqmp_dp: Unlock on error in zynqmp_dp_bridge_atomic_enable() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson To: Laurent Pinchart Cc: Dan Carpenter , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michal Simek , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20241112052754.GB21062@pendragon.ideasonboard.com> <37be000a-3ef8-4df4-aefa-b4d73487ad27@linux.dev> <20241112164305.GA24067@pendragon.ideasonboard.com> <5c2c6883-d81a-4869-9f32-48d23c0728ea@linux.dev> Content-Language: en-US In-Reply-To: <5c2c6883-d81a-4869-9f32-48d23c0728ea@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/12/24 12:22, Sean Anderson wrote: > On 11/12/24 11:43, Laurent Pinchart wrote: >> On Tue, Nov 12, 2024 at 09:41:58AM -0500, Sean Anderson wrote: >>> On 11/12/24 00:27, Laurent Pinchart wrote: >>> > Hi Dan, >>> > >>> > Thank you for the patch. >>> > >>> > On Mon, Nov 11, 2024 at 12:06:10PM +0300, Dan Carpenter wrote: >>> >> We added some locking to this function, but accidentally forgot to unlock >>> >> if zynqmp_dp_mode_configure() failed. Use a guard lock to fix it. >>> >> >>> >> Fixes: a7d5eeaa57d7 ("drm: zynqmp_dp: Add locking") >>> >> Signed-off-by: Dan Carpenter >>> > >>> > Reviewed-by: Laurent Pinchart >>> > >>> > Sean, how about replacing all the mutex_lock()/mutex_unlock() calls >>> > you've added in a7d5eeaa57d7 with guards ? >>> >>> I have no objection to that. >> >> Would you send a patch ? Otherwise I can do it. >> > > I can send a patch, but it will not be for a week or two. > > --Sean Just following up on this; will the above patched be merged? I would prefer to keep the bugfix and the conversion separate. --Sean