From: Shuah Khan <shuah@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>, corbet@lwn.net
Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: android: move config up a level
Date: Thu, 23 Aug 2018 11:05:05 -0600 [thread overview]
Message-ID: <11b89e1a-1543-5774-13f8-e004c8fc46ef@kernel.org> (raw)
In-Reply-To: <20180821161003.16737-1-anders.roxell@linaro.org>
Hi Anders,
On 08/21/2018 10:10 AM, Anders Roxell wrote:
> 'make kselftest-merge' assumes that the config files for the tests are
> located under the 'main' test dir, like tools/testing/selftests/android/
> and not in a subdir to android.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> Documentation/dev-tools/kselftest.rst | 2 +-
> tools/testing/selftests/android/{ion => }/config | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename tools/testing/selftests/android/{ion => }/config (100%)
Please split this patch into two with the Doc change into as a separate
patch.
>
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index 6f653acea248..dad1bb8711e2 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -159,7 +159,7 @@ Contributing new tests (details)
> * If a test needs specific kernel config options enabled, add a config file in
> the test directory to enable them.
>
> - e.g: tools/testing/selftests/android/ion/config
> + e.g: tools/testing/selftests/android/config
>
> Test Harness
> ============
> diff --git a/tools/testing/selftests/android/ion/config b/tools/testing/selftests/android/config
> similarity index 100%
> rename from tools/testing/selftests/android/ion/config
> rename to tools/testing/selftests/android/config
>
thanks,
-- Shuah
prev parent reply other threads:[~2018-08-23 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 16:10 Anders Roxell
2018-08-23 17:05 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b89e1a-1543-5774-13f8-e004c8fc46ef@kernel.org \
--to=shuah@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome