From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01B0C433E1 for ; Mon, 3 Aug 2020 06:18:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAA7F20672 for ; Mon, 3 Aug 2020 06:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728377AbgHCGSV (ORCPT ); Mon, 3 Aug 2020 02:18:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:60532 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbgHCGSU (ORCPT ); Mon, 3 Aug 2020 02:18:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16439AF38; Mon, 3 Aug 2020 06:18:34 +0000 (UTC) Subject: Re: [PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20200727091342.52325-1-roger.pau@citrix.com> <20200727091342.52325-2-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <11ba709b-6b9f-ff87-708f-60dd5200dcde@suse.com> Date: Mon, 3 Aug 2020 08:18:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200727091342.52325-2-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.07.20 11:13, Roger Pau Monne wrote: > target_unpopulated is incremented with nr_pages at the start of the > function, but the call to free_xenballooned_pages will only subtract > pgno number of pages, and thus the rest need to be subtracted before > returning or else accounting will be skewed. > > Signed-off-by: Roger Pau Monné > Reviewed-by: Juergen Gross > Cc: stable@vger.kernel.org Pushed to xen/tip.git for-linus-5.9 Juergen