From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D19E2C433E0 for ; Fri, 5 Mar 2021 00:54:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4A9864FD3 for ; Fri, 5 Mar 2021 00:54:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231916AbhCEAy3 (ORCPT ); Thu, 4 Mar 2021 19:54:29 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:24458 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhCEAy2 (ORCPT ); Thu, 4 Mar 2021 19:54:28 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1250XV2Q074732; Thu, 4 Mar 2021 19:53:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=QjoT81Wn3yRWvpjwuWUjGZfM3Z0jFdVtPmyURAKHe10=; b=VErkfFtf9aclGVqzlDva4eZv+B4cbxn/3kqIoNnBt1zUcP8mGjaoo+scKS8JsEawkwdF 5d74qEnisv48YmT4TS9rpyYseyl+3FkTRiwoJJaSVFTgrkpyabIjbUPZ3NdbsgBwHgkA qKRH4oiBIuCCOTpX+9O+6i+p7bP2LDnJZvofGRMl9a34eT1ncdOj0UPpfu6vjnSyXDww xt/OpZvDNuo82B39OVIb8MKsd4e/w5Ezw9f31uZBpfjlhh2PGJQby66ZA6Hka1srq3O4 ZOISYyUQyrOegh4ntwumKMCJxWpm9B/fPZjIgx/2b5+SIuPZhVv+mJIB5WiL2KLGdcG8 YQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 373a2crk4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Mar 2021 19:53:51 -0500 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1250XWdO074898; Thu, 4 Mar 2021 19:53:50 -0500 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 373a2crk4k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Mar 2021 19:53:50 -0500 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 1250ql4L027558; Fri, 5 Mar 2021 00:53:49 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma04dal.us.ibm.com with ESMTP id 36ydq9xrta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Mar 2021 00:53:49 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1250rme528115448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 5 Mar 2021 00:53:48 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D9272AE062; Fri, 5 Mar 2021 00:53:48 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C6051AE05F; Fri, 5 Mar 2021 00:53:48 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 5 Mar 2021 00:53:48 +0000 (GMT) Subject: Re: [PATCH v10 0/9] Add support for x509 certs with NIST P384/256/192 keys To: Stefan Berger , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au, dhowells@redhat.com, zohar@linux.ibm.com, David Woodhouse Cc: linux-kernel@vger.kernel.org, patrick@puiterwijk.org, linux-integrity@vger.kernel.org References: <20210305005203.3547587-1-stefanb@linux.vnet.ibm.com> From: Stefan Berger Message-ID: <11bd603d-56ca-b974-98e1-bc51238ea4af@linux.ibm.com> Date: Thu, 4 Mar 2021 19:53:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210305005203.3547587-1-stefanb@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-04_09:2021-03-03,2021-03-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 adultscore=0 spamscore=0 clxscore=1015 mlxlogscore=999 phishscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103050001 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Herbert,    you can take patches 1-8. 9 will not apply without Nayna's series as mentioned in the patch. Regards,    Stefan On 3/4/21 7:51 PM, Stefan Berger wrote: > From: Stefan Berger > > This series of patches adds support for x509 certificates signed by a CA > that uses NIST P384, P256 or P192 keys for signing. It also adds support for > certificates where the public key is one of this type of a key. The math > for ECDSA signature verification is also added as well as the math for fast > mmod operation for NIST P384. > > Since self-signed certificates are verified upon loading, the following > script can be used for testing of NIST P256 keys: > > k=$(keyctl newring test @u) > > while :; do > for hash in sha1 sha224 sha256 sha384 sha512; do > openssl req \ > -x509 \ > -${hash} \ > -newkey ec \ > -pkeyopt ec_paramgen_curve:prime256v1 \ > -keyout key.pem \ > -days 365 \ > -subj '/CN=test' \ > -nodes \ > -outform der \ > -out cert.der > keyctl padd asymmetric testkey $k < cert.der > if [ $? -ne 0 ]; then > echo "ERROR" > exit 1 > fi > done > done > > Ecdsa support also works with restricted keyrings where an RSA key is used > to sign a NIST P384/256/192 key. Scripts for testing are here: > > https://github.com/stefanberger/eckey-testing > > The ECDSA signature verification will be used by IMA Appraisal where ECDSA > file signatures stored in RPM packages will use substantially less space > than if RSA signatures were to be used. > > Further, a patch is added that allows kernel modules to be signed with a NIST > p384 key. > > Stefan and Saulo > > v9->v10: > - rearranged order of patches to have crypto patches first > - moved hunk from patch 3 to patch 2 to avoid compilation warning due to > unused symbol > > v8->v9: > - Appended Saulo's patches > - Appended patch to support kernel modules signed with NIST p384 key. This > patch requires Nayna's series here: https://lkml.org/lkml/2021/2/18/856 > > v7->v8: > - patch 3/4: Do not determine key algo using parse_OID in public_key.c > but do this when parsing the certificate. This addresses an issue > with certain build configurations where OID_REGISTRY is not available > as 'Reported-by: kernel test robot '. > > v6->v7: > - Moved some OID defintions to patch 1 for bisectability > - Applied R-b's > > v5->v6: > - moved ecdsa code into its own module ecdsa_generic built from ecdsa.c > - added script-generated test vectors for NIST P256 & P192 and all hashes > - parsing of OID that contain header with new parse_oid() > > v4->v5: > - registering crypto support under names ecdsa-nist-p256/p192 following > Hubert Xu's suggestion in other thread > - appended IMA ECDSA support patch > > v3->v4: > - split off of ecdsa crypto part; registering akcipher as "ecdsa" and > deriving used curve from digits in parsed key > > v2->v3: > - patch 2 now includes linux/scatterlist.h > > v1->v2: > - using faster vli_sub rather than newly added vli_mod_fast to 'reduce' > result > - rearranged switch statements to follow after RSA > - 3rd patch from 1st posting is now 1st patch > > > Saulo Alessandre (4): > crypto: Add NIST P384 curve parameters > crypto: Add math to support fast NIST P384 > ecdsa: Register NIST P384 and extend test suite > x509: Add OID for NIST P384 and extend parser for it > > Stefan Berger (5): > crypto: Add support for ECDSA signature verification > x509: Detect sm2 keys by their parameters OID > x509: Add support for parsing x509 certs with ECDSA keys > ima: Support EC keys for signature verification > certs: Add support for using elliptic curve keys for signing modules > > certs/Kconfig | 22 ++ > certs/Makefile | 14 + > crypto/Kconfig | 10 + > crypto/Makefile | 6 + > crypto/asymmetric_keys/pkcs7_parser.c | 4 + > crypto/asymmetric_keys/public_key.c | 4 +- > crypto/asymmetric_keys/x509_cert_parser.c | 49 ++- > crypto/asymmetric_keys/x509_public_key.c | 4 +- > crypto/ecc.c | 281 +++++++++----- > crypto/ecc.h | 31 +- > crypto/ecc_curve_defs.h | 32 ++ > crypto/ecdsa.c | 400 ++++++++++++++++++++ > crypto/ecdsasignature.asn1 | 4 + > crypto/testmgr.c | 18 + > crypto/testmgr.h | 424 ++++++++++++++++++++++ > include/crypto/ecdh.h | 1 + > include/keys/asymmetric-type.h | 6 + > include/linux/oid_registry.h | 10 +- > lib/oid_registry.c | 13 + > security/integrity/digsig_asymmetric.c | 30 +- > 20 files changed, 1256 insertions(+), 107 deletions(-) > create mode 100644 crypto/ecdsa.c > create mode 100644 crypto/ecdsasignature.asn1 >