From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6350A1E49B for ; Mon, 18 Nov 2024 13:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731934835; cv=none; b=Ex4isxX1Q5CmYFyUVLo3emjSq2ICatpHB513gTHDINi+GatxWYEyTT1rnhOAGhW5MlVRX0iPB6fxU5vfZpM7MI4BCXty/lWFdZBMkSGDTSUjctmHywoYxYtQA7YPJY3xHl0jeLHcM7IiF/s9nvobQI2m9HjgWynaRRHdhAhpMpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731934835; c=relaxed/simple; bh=KnMrBV+eNAVchflp35mrcRbGVqmoYRNEvJaP/XUdZRI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JsXQEaJbY2dkr8uxPBTmHFIcZlxUNlBFvD7EgE5ooCxeQU+xCAubKKEUFXrw3OFNT6RKg4jC6rB17lRt/rVS+ljNdJMMIIEIXbI0+k4VA9ZuAtP6a1BWcI2gLmm9vN0qOKyVFeFkUSxfpOa/MhTi3PhrDzunr3F0UYtoGr/V0Zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=oDOTJg/H; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=OJJponx9; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=JvIffgMJ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=2pt5Odh/; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="oDOTJg/H"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="OJJponx9"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="JvIffgMJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="2pt5Odh/" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 882E21F365; Mon, 18 Nov 2024 13:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731934831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=POCAvtbjbAn8l2UZV3oni2RrCLdjYMrNXKbkCUwnVXI=; b=oDOTJg/HS08v4qluhgz9sYxlARHb/mvm6zVBtcDo/y5kPtQCIuwzTuFGCYz32MA5mMtxft wF/miIfxV25thn0cGf7JF5Htk6lsa89BkGGALGIBTYMUZ4+lOJdV2zWbEGiKg9X8owdUdf xemp6pFjRge6a9LdSDcq+FHyoOMV/y8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731934831; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=POCAvtbjbAn8l2UZV3oni2RrCLdjYMrNXKbkCUwnVXI=; b=OJJponx9hocVmam/85kF4JbA67GKqES96kPbMvp9I4PzHdaQV9Yq2CxNT2ulF4uGPG9iD/ AHVZ0mUQ40mWbvCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731934830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=POCAvtbjbAn8l2UZV3oni2RrCLdjYMrNXKbkCUwnVXI=; b=JvIffgMJbJkG3UMWgkZUQxNpadZhzLHAzFoRLmREd0jjsJ0rUcOihpNYOhzleb1D3f+MJ/ 1DsTpOpjWdoBlm7OfFzOMFCRqV9utrVKTRZm08Il+apqICec4JvTu4gNhrO1lixBieLb3W Z1ZPb5Yiwn9EwZcEJquV9HeIEbTb6Vk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731934830; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=POCAvtbjbAn8l2UZV3oni2RrCLdjYMrNXKbkCUwnVXI=; b=2pt5Odh/Vb0VeKbfQ7HCYGCUBCraYnDWZrRXgCqbxz+8PlPbDhCCtm+UoW58trTVbiLSlt YATBXR2j2uz1aXBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 250A01376E; Mon, 18 Nov 2024 13:00:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wy0WB246O2e7XAAAD6G6ig (envelope-from ); Mon, 18 Nov 2024 13:00:30 +0000 Message-ID: <11c45b3b-4ffd-4587-9585-c62442f632f5@suse.de> Date: Mon, 18 Nov 2024 14:00:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [v2] drm: rework FB_CORE dependency To: Arnd Bergmann Cc: Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Jocelyn Falempe , Javier Martinez Canillas , Geert Uytterhoeven , Jani Nikula , Harry Wentland , Masahiro Yamada , Jonathan Cavitt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20241115162323.3555229-1-arnd@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20241115162323.3555229-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; TAGGED_RCPT(0.00)[renesas]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[15]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[arndb.de,linux.intel.com,kernel.org,gmail.com,ffwll.ch,redhat.com,glider.be,intel.com,amd.com,lists.freedesktop.org,vger.kernel.org]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[arndb.de:email,imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Flag: NO X-Spam-Level: Hi Am 15.11.24 um 17:23 schrieb Arnd Bergmann: > From: Arnd Bergmann > > The 'select FB_CORE' statement moved from CONFIG_DRM to DRM_CLIENT_LIB, > but there are now configurations that have code calling into fb_core > as built-in even though the client_lib itself is a loadable module: > > x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function `drm_fbdev_shmem_driver_fbdev_probe': > drm_fbdev_shmem.c:(.text+0x1fc): undefined reference to `fb_deferred_io_init' > x86_64-linux-ld: drivers/gpu/drm/drm_fbdev_shmem.o: in function `drm_fbdev_shmem_fb_destroy': > drm_fbdev_shmem.c:(.text+0x2e1): undefined reference to `fb_deferred_io_cleanup' > ... > x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_set_suspend': > drm_fb_helper.c:(.text+0x2c6): undefined reference to `fb_set_suspend' > x86_64-linux-ld: drivers/gpu/drm/drm_fb_helper.o: in function `drm_fb_helper_resume_worker': > drm_fb_helper.c:(.text+0x2e1): undefined reference to `fb_set_suspend' > > In addition to DRM_CLIENT_LIB, the 'select' needs to be at least in > two more parts, DRM_KMS_HELPER and DRM_GEM_SHMEM_HELPER, so add those > here. > > Fixes: dadd28d4142f ("drm/client: Add client-lib module") > Signed-off-by: Arnd Bergmann > --- > v2: keep the select in DRM_CLIENT_LIB, keep alphabetic sorting > --- > drivers/gpu/drm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index a4a092ee70d9..410bd6d78408 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -98,6 +98,7 @@ config DRM_KUNIT_TEST > config DRM_KMS_HELPER > tristate > depends on DRM > + select FB_CORE if DRM_FBDEV_EMULATION > help > CRTC helpers for KMS drivers. > > @@ -371,6 +372,7 @@ config DRM_GEM_DMA_HELPER > config DRM_GEM_SHMEM_HELPER > tristate > depends on DRM && MMU > + select FB_CORE if DRM_FBDEV_EMULATION This select statement is also required for DRM_GEM_DMA_HELPER and DRM_GEM_TTM_HELPER Best regards Thomas > select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION > help > Choose this if you need the GEM shmem helper functions -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)