From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE9B947B435 for ; Fri, 15 May 2026 11:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778843937; cv=none; b=TLV8fRS5TqAjAbJt3GdBuc8jkqXyPYZavRpwiE9qEdNEYEcVpsKM96MKDzxjfuOoXpziybnbxMyvO/FIOOzTSXj1N/JnKzF0/MCA44t/SDpwHVYUWuo1Dl+0JLpWTYseAKHojStoCfPGwtvJbXvNOreIz3OEqLMtAZSbbkEwHPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778843937; c=relaxed/simple; bh=UJVYFLt+7s0EoA6/cGgIfQ4tKtgAjAXLxZYsq54yp+c=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=KyfpNB2+K8VrH9uXBi0IPnUGOvbC3lnraPYrj7bw/CbF5hBEdyGtUKZUN9qHDfVVzVOU0IfEA3FhGNkqwcLbY7OnieJiubGfyDLmpFxLbn1vhezZTvPm56akQtaV9ksTwdWDbEdt+CpTGldfNUN289LKeBLCghfhX97k5LmgE0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XBbZAao3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H+LaRETU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XBbZAao3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H+LaRETU" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FAooLt655515 for ; Fri, 15 May 2026 11:18:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KCGXkWeRm3I5kdOwASc8lBJELQDGMPw3e9LMXhleB4U=; b=XBbZAao30viDbXZj xpKBXDPxtl8gV4AlXbfxTZ6nVwKhUCVCKCKmrGDWJraArwh8WKLIzMERe9wzhytj gcU/noia15CYHRUTYz4KMOWBYffz3x2Dog6OrHMxNYw2qm0fVDRpgUgsnstl34ZG 8TroHqRVjRhS617HCfJfwzLbsgCwgEER/36Tzq2rtyCAxBDw307b1+uAcRIPoTfz 5hms5Bn5u0r27SBl83+EiG1KT9z06Fl20bTksqImeBdT4b84SLVmUs/bq1eyZjzO C+OVsxYZ/15p9OTiV5JNGUA0LVw/ZBPb1FnxGequrAGfl3yBDQxyyB7ES78zdc71 w+A/ag== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1pu2c3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 11:18:55 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-368ac44b26dso4917805a91.2 for ; Fri, 15 May 2026 04:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778843934; x=1779448734; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=KCGXkWeRm3I5kdOwASc8lBJELQDGMPw3e9LMXhleB4U=; b=H+LaRETUyb33znpIqdd0jU7AivUmcvWeBtwTXb9vzLxCbPNTHzEkUOBxGZsLDKd+Fq loCpJ819ZkaKF6gnVDOZtBkP8ejJmSbXX4RGFjKT+uozm8YQhXziQEXwYZCIbsLU+fAp NDb1fLKmcpor9/9XFdMv6Pl6hLA9B+MLXy9Dq6j9Ggv+RS7mRI9JjnB1K7x62YlI32RI 3lsddoxM2JdWVELfqm8r0SzRSH7eea8AU31J6vRmu87IuZJGXcw6toRh1XEkkBBWVnWF +Q1f22zG9EQNvePVizRQzFadpGCVIGscha9NCgDK4q5IerpDXbNpXXDLmUL236MxfCoI n5JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778843934; x=1779448734; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KCGXkWeRm3I5kdOwASc8lBJELQDGMPw3e9LMXhleB4U=; b=Hy4G6LEVsAbxwb1a+Fioi1450XhzeMa6zd0b//+xMA5IbI4/duAHyJFnzmUB5TbzGu wsgkFTlldYdLNlcCCSgfhWx+rA9s50Yi7bj84mv222C9T8D6fGXVMGAiGGWBry+51USl V9BUPObqJkDAj8woBE+7/nr3PuNGuxTqor/fB5hfZyucRpzm+yeSA7zePO5IHcB0y+Ri 4Vce3h8pbRRoOZHrolSJH+zmIB18PqFi4ZYPgC0MgzMky8l34G0E2TkxHPCtg7wssTbA NbPO0chWJ+OrHk8vXuwtrY75bUcZBRD65Wp7wRntpYbBgz+UlTD5/hSSbennMgjo7DQm 81TA== X-Forwarded-Encrypted: i=1; AFNElJ+Z34lcrWMNkbGR6X6KF31jxQTgDuus9wCVe9ZMdIffoYs9g4k1QCDlvJt22MqG8ifXDnhGwdW/v+ZLLT8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9V5lBWjvU5VLbfayIU1rJ2b9JbCuTfMvEyT3sgZ4Tn1JBuEas Uk+/UAFltW7VNOL1/9/ggDRUs9u5+oc91MXwItU7qhPkeC3weJxwL0zLVazcxIDY0bEWr4alhQc f5Jk6td4NUIREJTFt/Q9C9cURsSsbGR8VvoFSZgjmr4A84ZQFHf5S4iBQdM//X61o47I= X-Gm-Gg: Acq92OGj3Hon7Dq7DEzZWGpOYEBXMIjt1OZko+ZisOC01wyqEH3JLbdN352qoqQUaiZ iZJPqBDpKNVjDgFVPK4Q636xTiBlX6EY9Gq+f9Qh7NsP5n1yjh92/FOpEZwK1kATf4ttTn7vxOw 4/VWW4W+syWTi2jmEO5ZYEd3js+unTx7HtLVX49KKjeklCzKkB2vpsi9ECeMa1wtZQQWQWztHQC yc3wvYRwRmEW0EPur+s6RjS0n7QrzqBev3x8bGby8n7XmshWFi2D8Yp+pqxyimyZRZwUHVqef8h GUhviBpWMOPkhpWl0QRdAbl0idon/Yi4mqnQi1eLdEF6eTrllQfAwBuIgavnZKtdh6ZRy2RNq7r AzC3zEsknOx42RcASAPHYikHqW9K/rsfEJjITiglXpkwpD2Br3G2CHA== X-Received: by 2002:a17:90b:38ce:b0:365:fd4b:24f5 with SMTP id 98e67ed59e1d1-369519c513bmr3273092a91.8.1778843934524; Fri, 15 May 2026 04:18:54 -0700 (PDT) X-Received: by 2002:a17:90b:38ce:b0:365:fd4b:24f5 with SMTP id 98e67ed59e1d1-369519c513bmr3273045a91.8.1778843934003; Fri, 15 May 2026 04:18:54 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3695126feabsm2470123a91.6.2026.05.15.04.18.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 04:18:53 -0700 (PDT) Message-ID: <11c63862-5e8b-9f3a-5479-706e672879a5@oss.qualcomm.com> Date: Fri, 15 May 2026 16:48:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH v5 03/14] media: iris: Fix VM count passed to firmware To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Hans Verkuil , Stefan Schmidt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Jorge Ramirez-Ortiz , Del Regno , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, Krzysztof Kozlowski , devicetree@vger.kernel.org, stable@vger.kernel.org References: <20260509-glymur-v5-0-7fbb340c5dbd@oss.qualcomm.com> <20260509-glymur-v5-3-7fbb340c5dbd@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: wPmSXQrcWlYE-5Zf6BxEXzTG2TJnBO4f X-Proofpoint-ORIG-GUID: wPmSXQrcWlYE-5Zf6BxEXzTG2TJnBO4f X-Authority-Analysis: v=2.4 cv=GrhyPE1C c=1 sm=1 tr=0 ts=6a07011f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=5Xy_6AgtP5T3jK3p2aAA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDExNCBTYWx0ZWRfX5fhJ9Jy6fFyp mH3Cf8z0QolXPGA7I0f2ziv0lItKS5STqEsrz5KPPt44oyxNCM8Fbb/akhv9DerkqXFxtoWbSkm emZXfafBfUH+06+rm41qiAJDp9dAgv7KwCVicFxqAMMJNa9QXZuqQRyOWgfZ4cOMN/nIl+qAUEi GDR4kNhFaREiPIGE2drcWWOaCxGPkRFGeQNfrhRidnWIY940pnrtM3RAApkwnCqm7W/At2KsInV OuF0gGDCxCcln0ddPSMyNUUdKGul3avfJqwtFw00ZbfaD0hIk5hTcJxfKLYMqlDFjUz5nmoqLnB B/bLKfCMsGqg6xbT3CiAbkiZp2BxsL7sYiNWYEJRbsse1at+xkBMGg9BUJphA05yRK0u0crCvQU u+ecj9566NvmHy8halKrKuCPtXOl2bEuRZ1Uhn+3iYwNk3dJA92lOw1HvU26MG129fJMBfnll+l qTQ1vv176qiiiso7/Pw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150114 On 5/9/2026 12:50 AM, Dmitry Baryshkov wrote: > On Sat, May 09, 2026 at 12:29:52AM +0530, Vishnu Reddy wrote: >> On Glymur, firmware interprets the value written to CPU_CS_SCIACMDARG3 as >> the number of virtual machines (VMs) and internally adds 1 to it. Writing >> 1 causes firmware to treat it as 2 VMs. Since only one VM is required, >> remove this write to leave the register at its reset value of 0. This does >> not affect other platforms as only Glymur firmware uses this register, >> earlier platform firmwares ignore it. > The explanation is pretty suspicious. I can see this write in venus > sources too and it was added in the initial submission, dating 2017. The > driver targeted two platforms, MSM8916 and MSM8996, so this write > predates Glymur pretty much. Thank you for the historical context! I checked with the firmware team and confirmed that this register is not read by any of the platform firmwares currently supported in the Iris driver. Regarding MSM8916 and MSM8996, those are not supported in the Iris driver. >> Fixes: abf5bac63f68 ("media: iris: implement the boot sequence of the firmware") >> Cc: stable@vger.kernel.org >> Reviewed-by: Vikash Garodia >> Signed-off-by: Vishnu Reddy >> --- >> drivers/media/platform/qcom/iris/iris_vpu_common.c | 1 - >> 1 file changed, 1 deletion(-) >>