From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbdCPI6C (ORCPT ); Thu, 16 Mar 2017 04:58:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53488 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbdCPI6A (ORCPT ); Thu, 16 Mar 2017 04:58:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 129D9F622C Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eric.auger@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 129D9F622C Subject: Re: [RFC PATCH 12/33] irqchip/gic-v3-its: Rework LPI freeing To: Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <1484648454-21216-1-git-send-email-marc.zyngier@arm.com> <1484648454-21216-13-git-send-email-marc.zyngier@arm.com> Cc: Thomas Gleixner , Jason Cooper , Christoffer Dall From: Auger Eric Message-ID: <11c696bd-b044-285e-a699-716e644a1a99@redhat.com> Date: Thu, 16 Mar 2017 09:57:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484648454-21216-13-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 16 Mar 2017 08:57:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 17/01/2017 11:20, Marc Zyngier wrote: > Rework LPI deallocation so that it can be reused by the v4 support > code. > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-its.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index dce8f8c..5d96b37 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -865,10 +865,8 @@ static unsigned long *its_lpi_alloc_chunks(int nr_irqs, int *base, int *nr_ids) > return bitmap; > } > > -static void its_lpi_free(struct event_lpi_map *map) > +static void its_lpi_free_chunks(unsigned long *bitmap, int base, int nr_ids) > { > - int base = map->lpi_base; > - int nr_ids = map->nr_lpis; > int lpi; nit: while you are touching the function you may add a blank line after chunk declaration in the for block Besides Reviewed-by: Eric Auger > > spin_lock(&lpi_lock); > @@ -885,8 +883,7 @@ static void its_lpi_free(struct event_lpi_map *map) > > spin_unlock(&lpi_lock); > > - kfree(map->lpi_map); > - kfree(map->col_map); > + kfree(bitmap); > } > > static struct page *its_allocate_prop_table(gfp_t gfp_flags) > @@ -1654,7 +1651,10 @@ static void its_irq_domain_free(struct irq_domain *domain, unsigned int virq, > /* If all interrupts have been freed, start mopping the floor */ > if (bitmap_empty(its_dev->event_map.lpi_map, > its_dev->event_map.nr_lpis)) { > - its_lpi_free(&its_dev->event_map); > + its_lpi_free_chunks(its_dev->event_map.lpi_map, > + its_dev->event_map.lpi_base, > + its_dev->event_map.nr_lpis); > + kfree(its_dev->event_map.col_map); > > /* Unmap device/itt */ > its_send_mapd(its_dev, 0); >