From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yang Chen <yangchen.openbmc@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
joel@jms.id.au, andrew@aj.id.au, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
patrick@stwcx.xyz, Jerry.Lin@quantatw.com,
Eddie.Chen@quantatw.com, EasonChen1@quantatw.com
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva CMC board
Date: Wed, 13 Sep 2023 17:41:57 +0200 [thread overview]
Message-ID: <11c822f3-96f1-17d6-6c2a-feaa950aeea1@linaro.org> (raw)
In-Reply-To: <CALFa7M_GvCgmEZxvo_ZSYoCPOe+9-tQt3KHn=_cu3n7psP+PTA@mail.gmail.com>
On 13/09/2023 15:57, Yang Chen wrote:
> Hi Krzysztof,
>
>> +
>> +&i2c15 {
>> + status = "okay";
>> +
>> + eeprom@50 {
>> + compatible = "atmel,24c128";
>> + reg = <0x50>;
>> + };
>> +};
>> +
>> +&adc0 {
>> + ref_voltage = <2500>;
>
> There is no such property in the bindings.
Fix your email setup. This is my response, not yours.
>
>> + status = "okay";
>> + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
>> + &pinctrl_adc2_default &pinctrl_adc3_default
>> + &pinctrl_adc4_default &pinctrl_adc5_default
>> + &pinctrl_adc6_default &pinctrl_adc7_default>;
>> +};
>> +
>> +&adc1 {
>> + ref_voltage = <2500>;
>
> NAK, there is no such property.
>
So who says what?
> Thanks for your advice, I will change this property to
> "aspeed,int-vref-microvolt" which is defined in the binding in the v2 patch.
No, why? Drop it. There is no user.
Also, do not top post.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-13 15:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 14:05 [PATCH 0/2] Add CMC of Facebook Minerva platform yangchen.openbmc
2023-09-12 14:05 ` [PATCH 1/2] dt-bindings: arm: aspeed: document board compatibles yangchen.openbmc
2023-09-13 8:20 ` Krzysztof Kozlowski
[not found] ` <CALFa7M_Gov4jd3wxrXWhxuPKbDr+cp8xmuWJCQH_N=a+q03M1A@mail.gmail.com>
2023-09-13 10:05 ` Krzysztof Kozlowski
2023-09-13 14:19 ` Yang Chen
2023-09-13 10:03 ` Krzysztof Kozlowski
2023-09-12 14:05 ` [PATCH 2/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva CMC board yangchen.openbmc
2023-09-13 8:21 ` Krzysztof Kozlowski
2023-09-13 10:04 ` Krzysztof Kozlowski
2023-09-13 14:06 ` Yang Chen
[not found] ` <CALFa7M_GvCgmEZxvo_ZSYoCPOe+9-tQt3KHn=_cu3n7psP+PTA@mail.gmail.com>
2023-09-13 15:41 ` Krzysztof Kozlowski [this message]
2023-09-14 7:06 ` Yang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c822f3-96f1-17d6-6c2a-feaa950aeea1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=EasonChen1@quantatw.com \
--cc=Eddie.Chen@quantatw.com \
--cc=Jerry.Lin@quantatw.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=robh+dt@kernel.org \
--cc=yangchen.openbmc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®