From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AFDA305688 for ; Mon, 18 May 2026 07:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779089721; cv=none; b=CidkCnOzLheuMobAkk3z5wqxUlJrkip9sW6x8nrtPvSLfEpfzVjj2fxRv4rLVqwEay46tgqFsfBagnTKcEhGC/QZLggVi1qCCLjSbQ6mF2hR5rXkRnTe+yGp+jehX4UB462FDy7KPi06cQfuIa26XvriTvjq7ZOaQ2cJIYI74w0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779089721; c=relaxed/simple; bh=xAxy7fO2YlpiPg7YUBfWrXYpsnJqHkDmbkTaqIyM1LM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R91Ex3CGnpnOZYuG3rIGZlCUZuzuvH66+uebOtlYhH02CavUDXzXgZyAkNe4o++SUsrqPZDLwvF+m6qweymTC/Z7EIMhKK8hXsdWXfSioO89Qk7y4/iHW2RovoklVrpfPZZ9E0ICjH1+2NnZg0I3p8Zb4p6/1ZEvwQvFye7vXfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NX61KUrC; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NX61KUrC" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-3937014be0cso19242941fa.0 for ; Mon, 18 May 2026 00:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779089719; x=1779694519; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wWkpCpQ0FJ7/KTqsrEBZy/g0n+sB4k/74RUvdqaLZAk=; b=NX61KUrC1uZro1+RMrqjUnudB6XMDVmlpnlDTVMfCkW5Qeuw0Cz1lOdjnS/GkwSTJH jq0/621dHTbHSkA7biYG40w66nIKY1OIFQRxklHP64td0bzSq6nvtm5hKwz59baqtIP0 oTvn09Poe02Ul4MPwp9xDoV0/iwu2lNPPtDxJFP+eRdes4RxKz+Gp6alJTWudRvN9POr K9E94ymI5P0N7vZJ3E7n2Z/j/b8m45NVzYBQjiUueJoGH6mbLS1JkcXDR4mYZT60YViz 07O3f12+ncZzy4J6ofy80CfjxfFASjaPd0tOWRGvJWMRQVsdumc9OwuJFSX228qu3pLF QAzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779089719; x=1779694519; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wWkpCpQ0FJ7/KTqsrEBZy/g0n+sB4k/74RUvdqaLZAk=; b=BkbmkNCrYEpQoQUasPJ+rKPOB0DGEwpmUlVGzWh+d+AcHxwO5y3w1wnuOhvVhjQdMx zz0TxHk0TwJ6W8cApK5ngqob/cbUb3E3Yu3eFjHzZua3c/YELB9nzJ4wyB+5kIKBI9xK s9juxL65KsSkpRbWtSiBEbIyHZqQRAL5nyUWkjssqRUVsRN0LoX1J2uk9+1imWPzeZ+q W1bG1MaFGn3eRzO34by88xII+YQJX1Am2cfow5KvV5UDNHZSCOHF91OX0H/AECbFwBFE lIQ8pGGpVyKKS0A2t5C99PZETWnGh81RE3V51IcJUZJf/GY1TvI28j2nVmBK5IyCibja dzWQ== X-Forwarded-Encrypted: i=1; AFNElJ+hCbeXvvDeN1cLH/vB4sjRHrW00+Xn6BBPABnkPo7PTRmjdPk7Yei7TsvCrN2k5Pge4xTsKT8UlF4NFUg=@vger.kernel.org X-Gm-Message-State: AOJu0YxOtVN/Eh1D/6iGoqBS3sZ7WCy3ClncJLjGsuP/kUqa5tZU+N2Z heTg1R3YMWCpqb4jTeL0J6V6Mls8wIPwoTWmBnRLwJGiIv1YIvyojMO4 X-Gm-Gg: Acq92OH28RutdD2RI69Y0yHd4FsmV0QZfiFTa4oMqVVIx5gcyqI9ZY8isTX7ME67THE GRueB7rOKuZlp6IeLivPBz1sz8FW4ULv7t10ctjms3zA2ONNp4kLXoMTulHv8uGVd7mwfNKkX+R 26Umuyab9Cq0ks2I7Fo75IqpgW1ay5mYGLkzGWYLnG73C+qspwySPT1WgJH79OpHmFxt8trNQuk 9pHt2W0sJk0jmQWI5EjoPLjIQu4Setm5FhxcVWJSimx2s2CubOOJpy6UkbogvEGppBn1gY9xJID VkOdRtCL0a3wPlkcFKlgzbjNCPy/wHnhV95n6cQ/RBdhwaeMlXiGQ8oHQGhJJVre0mM0svjzo8o EnGyj8251VX/+JIEDRFOb1pgXQX5KKuDG+fwp54NZDMj8GI4GoN5abhULYH/0jCGhmo1LZoumZj ZBzqIEzuN616RdKkGHl4GS/ZUzTP8kAWEr X-Received: by 2002:a05:651c:1503:b0:393:bffa:d815 with SMTP id 38308e7fff4ca-39561fec6ebmr35018191fa.21.1779089718284; Mon, 18 May 2026 00:35:18 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395887b4064sm9563661fa.33.2026.05.18.00.35.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 00:35:17 -0700 (PDT) Message-ID: <11ce9c58-25ef-4c47-b3d6-7d189d3757c6@gmail.com> Date: Mon, 18 May 2026 10:35:16 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: pressure: rohm-bm1390: notify trigger on all error paths To: Andy Shevchenko Cc: David Lechner , Stepan Ionichev , jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260517160801.269-1-sozdayvek@gmail.com> <54ee1fba-3209-4192-82c3-674a1ae3ca8f@baylibre.com> <3cb30f12-8b4f-415f-9a1d-823d8ff8c33b@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18/05/2026 09:59, Andy Shevchenko wrote: > On Mon, May 18, 2026 at 08:21:17AM +0300, Matti Vaittinen wrote: >> On 17/05/2026 20:12, David Lechner wrote: >>> On 5/17/26 11:08 AM, Stepan Ionichev wrote: > > ... > >> Maybe it would be better to do something like: >> >> void iio_trigger_poll_nested(struct iio_trigger *trig) >> { >> int i; >> >> if (!atomic_read(&trig->use_count)) { >> atomic_set(&trig->use_count, >> CONFIG_IIO_CONSUMERS_PER_TRIGGER); > > Just in case somebody is going to do that, avoid doing atomic_read() followed > by atomic_set(). This is typical TOCTOU issue. This should be something like > atomic_xchg() or atomic_add_return() or something like this in a single atomic > operation. Well spotted Andy. This is existing code, so perhaps this should be fixed if the logic won't be altered after this discussion. Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~