From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793380745; b=edESh0ApNBHC2U8kZiCY2wyr+1N+o1lumCB6TReSdgnoqoKQFCbL9d+MUZ27uX1QOYfe F8kU2ZsU9E6kj75xNLyjR9Ky9UFoeG6cNqeR1rv1tm2xX9qocqtTnN1i9cKhuaONGzpFU xJkemFm5Tih4r9GXE1iBafavSD1nvhihiohPakhroGKcghcbQKf3oPR83hU/gmyLo/f7d iZ/mY+bW5up+vaxWlHsrELfLAC3YgeNxEZTVUH+HvQrjGlcfYt14rVCd48fsptCOwsiUY jVguUKWTt+VPoplbBhGIUxvmzEg2BaVWC8XQThj0hEBPeoRDdgAqPcmiqPfr7wUC1XA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793380745; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Authority-Analysis: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Info:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=LztxLNl/cxBUH5XhoVCY5HWh+124EuWqYRgWVaTkemI=; b=kcCqhdHUAB9iuX8duKUer5zbLVORrAawmJkXww0/RlfV1mIeEjxiwHZ54PLSP/8frc14 vUdN8c98Nf103/adJQ68SeRmunOx+WGOoENHBFfJZh5q9eoGSWEtlF8/MzKiQPu/7MMpo mIve/D9tV3pjJrl0ucFL7h/6wNTlEem/oQv6mv2cePrbMFk2I+ZjFtj7BmLarKvr3YNfH LW1HBhYelGz92s3ULNs8krqUyzoepQ3xP34DdKyFizjzF1kDaAM3jjMg4xePP+ffSezjx mPaeo1XUUiaU6v+eAYLGMZazHMqUQnOAMTpMQUcpcfnx21Ja64lQCBwWat3CEAX1F0A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=bI6s7Wzt; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=berzHw0L; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAF74606A320 for ; Fri, 30 Oct 2026 17:19:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BAF74606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=bI6s7Wzt; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=berzHw0L Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69UERAnG3515380 for ; Fri, 30 Oct 2026 17:19:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LztxLNl/cxBUH5XhoVCY5HWh+124EuWqYRgWVaTkemI=; b=bI6s7Wzt5RY1O8qb Y69aVd5U3HUS7vWVvI6035fPSKCxFs4pl12z2tNrlwnTS0DzHG9oh3pYA9QU5n25 HMZLYfzm1wv8I9qA6/SaFgs67DiB9TwTpsARVffqccqUyIkOiq16GikcqKy/3ptI /kxY+kekfRSso2oTMGsyVcFlkPxmzTp1DqpVNHqlo2grOnza6ZAib5olImyjtUxz hxZr1OlExF2aO3+qCsq0+fW+eYm3Bd7FrT06/lOS72KMk75nLSGCpPtxmKMhYyP6 Z9BNKHJ9k2xPIMzpJAdBZnoPmHE6KrLIkUyMrQ1D2EAxm3nd4AziX3uchjhXWlEN zJn8Ew== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hme6qm7y3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Oct 2026 17:19:03 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-844bc76180bso1216426a34.2 for ; Fri, 30 Oct 2026 10:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793380743; x=1793985543; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LztxLNl/cxBUH5XhoVCY5HWh+124EuWqYRgWVaTkemI=; b=berzHw0LM/RQkAlDtkef8WovWMVceMsDKNlqFPhwgiZaCEoljpXD64EjIaEkRTjucm jpCcoHx9kSFHa3OcMTkuJoPmHXM5aWvMY18clZIzWy+RJh/41fbjXXBd3qz8s90NzNS7 3EiW1expVdOG422Vdf9jWEKgM3NF8rMThZZOd6IACe0rIEcIsB9TkBUww9MdvcrU26P8 YEPvkktqzINXV2uHktPvJ8QuQ7kEfgkT0VRaaPLaFOACPsyuoTnS6JpklJh76LxtD7DS 6WbngRNBu7LWDEu8M4Yq9fJNP3IjEPUzqptd241O2YPhL5z4dha8MrwEo2GD0YpfSZaR QqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793380743; x=1793985543; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LztxLNl/cxBUH5XhoVCY5HWh+124EuWqYRgWVaTkemI=; b=VB4mKqZZgoNXd3TyQP7ZYo5jpeysNIAPXuBI5P5T/LD7AV5kq3aPphVZNDkMA3e0lU 1IH98t25W0/1WV6rG7PQ9lLXV3UmBMpX0069A5/etzG55Y9Ac4sdPZNBV2EI5J1eemL1 7+Xg5Cm93aFSNdRj0PnnYIkbpMLTN5wJPKxT5bvgjcazCfduPpY2A4oOkbc8ylXkNvSQ b2NL7tFMIq1NdRvHlLRlIAox0buCtNUFTemyDR8Ul06Zxmr0duweMp4qYuIuijX/UE31 Q4jdqQP0FHYCtSlTPZoaiXrIcmlskIQtNZF5Ygr720iKScriNJ34Z9mCpa6lyG8TcByP 2sNg== X-Forwarded-Encrypted: i=1; AKwUvBzTpN2BQeYAqpGCkHAwJXwU7Ke91PZzg2sLE0Kg2s4Wecmk6ZBHVWNRuylRGsz8F3DfQMlT6d/oxCbNqFM=@vger.kernel.org X-Gm-Message-State: AFq9FYKcP9xEJ9VVpfpp3OmoEl1p3f+ATajKKGch9V+XiWCDP697gbxj ZC9aND5pj5DcDvT0ZpLJMZbA2VLHZ6Vpw7kesKMdaBBCrSlURxcku5lXcsocdK3+Hu8bqI586qW M4XY/uaInAlaDX09J8wHeUEO0UDwsO1Fz3M3ZtLU/fonxgkETCuNZYzrebniPX5z8aZk= X-Gm-Gg: AYBFou3ECVZb+RFMsZCawilLKTwK9M7gUCmZR0yTo0KBnecXyETiy9T8bJJxWRuan2J 5x3DuvG7pDjcJHmfDUQLz5VDPm/ZdMbZ6xNzlfrD5HWYc90LK+KM7Ngg1/g6RmlW4/hA7CnzLsF ymcWB0LI6IxjGy5dPBm7J8HSh7h1yNxkNtedDw0zEri/SK9RlJr9x4eDy3QYqEj3uXTjmxIOFbe v0Xz82SB8IWZlkm6iSouPG61nwlsAtwt4a2QWETFFKzj31lGCFR6NzFLv4OZ4fa6UuApreyzp2o KMLXt5S5upAAzmZvleaph//XpDzeSCT7iP4Np8cE0JtZmY3qbXdqEFD59lnT52mJHMQEJrylAqW uh8KsxkBGfsVfODg+swuhcJEtlLQGeNpbCYgY6DX3kkR1xRI1/JfURStMPzjvJqmaExZYtfIv4V XK6P15YeJP4rSjVZ6TkyVd2M/7xirzqJ2TFYBqhh20xi/18kikqVCvnKjpz+e9P6DW X-Received: by 2002:a05:6830:43a8:b0:81b:c62c:b63 with SMTP id 46e09a7af769-85d3654bc97mr2516116a34.18.1793380742784; Fri, 30 Oct 2026 10:19:02 -0700 (PDT) X-Received: by 2002:a05:6830:43a8:b0:81b:c62c:b63 with SMTP id 46e09a7af769-85d3654bc97mr2516083a34.18.1793380742316; Fri, 30 Oct 2026 10:19:02 -0700 (PDT) Received: from [10.50.42.16] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-85d355295fbsm2491106a34.25.2026.10.30.10.18.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Oct 2026 10:19:01 -0700 (PDT) Message-ID: <11d12057-11ce-46dc-8310-be660838515e@oss.qualcomm.com> Date: Fri, 30 Oct 2026 22:48:48 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] arm_mpam: Fix MSC MMIO window size off-by-one with resource_size() To: Yin Li , James Morse , Rob Herring , Shanker Donthineni , Ben Horgan , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Reinette Chatre , Fenghua Yu , Jonathan Cameron , Bjorn Andersson , Konrad Dybcio , Gavin Shan Cc: Andre Przywara , Drew Fustini , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Shaopeng Tan , trilok.soni@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, ganapatrao.kulkarni@oss.qualcomm.com, Huang Yiwei , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, devicetree@vger.kernel.org, kernel test robot References: <20261028-mpam-resctrl-dt-knp-support-v4-0-bdda1e445cba@oss.qualcomm.com> <20261028-mpam-resctrl-dt-knp-support-v4-2-bdda1e445cba@oss.qualcomm.com> Content-Language: en-US From: Srivathsa L Rao In-Reply-To: <20261028-mpam-resctrl-dt-knp-support-v4-2-bdda1e445cba@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: J8xJALzIWC5Ejbxb7_EQ0K8ESu_st-2b X-Authority-Analysis: v=2.4 cv=KLzPn1Fo c=1 sm=1 tr=0 ts=6ae4d187 cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=7CQSdrXTAAAA:8 a=lcbwfqp2WOkoDi6s_FAA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDMwMDA2OCBTYWx0ZWRfX5/e1SzTPfIA0 9SffqlU4SRsK2EUy+y474qmjC3Y4zZYsX5wgvJdQW9HObS6ZjekZriHZPIvPoCypZ+VapbkU4MA huFhZ0iJo2cUj/g2ci/4A5NsEnB5/afotxC4wRrqKiNawjs+RjdlZi/4XPYWx13WS2q1rd/xiJO TwbktFBsP96CDsu77IvUxYmrP61+vfOGngoBVO+j/c96XVsU18L5epNnDzqOLsqc23fQ8w8aodG C8YLlOmFLpKun07Z+8WLaH98a4JFAlEPstjlECsEYSeglBg9zhpUpyGl5QRp9xujYyJjyFNQRX4 uT9aXR0zBjibn6Cp6bw21MP+luFVn8KqAVKMMa+FvvpASNkH0cWw3y48NbUWa2m5el8gxvLUdYI wim/FI9apnAnsPVWh0IASVhqzm/V52QXY4DyPrL3+spwrL1PzSWghjnkvzBxDdPC0Znm7urkI6C VU61NwIz/2k1nhZgH+A== X-Proofpoint-ORIG-GUID: J8xJALzIWC5Ejbxb7_EQ0K8ESu_st-2b X-Proofpoint-Spam-Info: AW1haW4tMjYxMDMwMDA2OCBTYWx0ZWRfXzbG9MGElxOtB 9CscMZk2L8cgt2NA2eB+Wv+FUhVib/botA8FaQXDLRzrhWM7aLU6PYu7//niiqIHxZdD2Luwe62 bnnXkCEOGKT/M/VG/awp8YcEacaagEA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-30_05,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1011 bulkscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610300068 Reviewed-by: Srivathsa L Rao On 10/28/2026 5:15 PM, Yin Li wrote: > struct resource uses an inclusive end address, so the window size is > end - start + 1. do_mpam_msc_drv_probe() computed it as end - start, > which is one byte too small. > > mapped_hwpage_sz is used by the register access bounds checks, which > have the form "offset + width > mapped_hwpage_sz". With the size one > byte too small, an access to the last register in the window is > incorrectly flagged as out of bounds: for a 0x1000 window, a 4-byte > access at offset 0xFFC (bytes 0xFFC..0xFFF, legal) computes > 0xFFC + 4 = 0x1000 > 0xFFF and falsely warns. > > Use resource_size() so the size is correct. The ">" bounds checks are > correct as-is once the size is accurate and are left unchanged. > > Fixes: f04046f2577a ("arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202609030809.ObirDhR3-lkp@intel.com/ > Signed-off-by: Yin Li > Reviewed-by: Andre Przywara > Reviewed-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 347a5a6d6a1d..0f984fcbcae9 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -2508,7 +2508,7 @@ static struct mpam_msc *do_mpam_msc_drv_probe(struct platform_device *pdev) > dev_err_once(dev, "Failed to map MSC base address\n"); > return ERR_CAST(io); > } > - msc->mapped_hwpage_sz = msc_res->end - msc_res->start; > + msc->mapped_hwpage_sz = resource_size(msc_res); > msc->mapped_hwpage = io; > } else if (msc->iface == MPAM_IFACE_PCC) { > u32 mpam_fb_msc_id; > Best Regards, Srivathsa