From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
David.Laight@ACULAB.COM, davem@davemloft.net,
gregkh@linuxfoundation.org, stable@vger.kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ide: Check for null pointer after calling devm_ioremap
Date: Sun, 9 Jan 2022 17:53:39 +0900 [thread overview]
Message-ID: <11d2e187-03eb-9a66-56ad-337fb5996b7b@opensource.wdc.com> (raw)
In-Reply-To: <20220108035552.4081511-1-jiasheng@iscas.ac.cn>
On 2022/01/08 12:55, Jiasheng Jiang wrote:
> On Sat, Jan 08, 2022 at 10:53:42PM +0800, Damien Le Moal wrote:
>>> Cc: stable@vger.kernel.org#5.10
>>
>> Please keep the space before the #
>>
>> Cc: stable@vger.kernel.org #5.10
>
> Actually, I added the space before, but the when I use the tool
> 'scripts/checkpatch.pl' to check my format, it told me a warning
> that it should not have space.
>
> The warning is as follow:
> WARNING: email address 'stable@vger.kernel.org #5.10' might be
> better as 'stable@vger.kernel.org#5.10'
>
> So I have no idea what is correct.
> Is the tool outdated?
> If so, I will correct my cc and please update the tool.
>
>> As commented before, what exactly was corrected ? That is what needs to be
>> mentioned here. In any case, I fail to see what code change you added between v2
>> and v3. The code changes are identical in the 2 versions.
>
> Thanks, I will make the changelog more clear.
> In fact, in the v2 I was careless to write '!!alt_base'.
> So I removed the redundant '!' in v3.
>
> Please tell me the right cc format, and then I will submit a new v3,
> without the problems above.
Cc: stable@vger.kernel.org # 5.10
Should work.
>
> Sincerely thanks,
> Jiang
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-01-09 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 3:55 Jiasheng Jiang
2022-01-09 8:53 ` Damien Le Moal [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-11 3:01 Jiasheng Jiang
2022-01-09 14:01 Jiasheng Jiang
2022-01-11 2:23 ` Naohiro Aota
2022-01-07 12:53 Jiasheng Jiang
2022-01-08 2:53 ` Damien Le Moal
2022-01-07 11:50 Jiasheng Jiang
2022-01-07 12:07 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11d2e187-03eb-9a66-56ad-337fb5996b7b@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®