From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F583161A5; Fri, 30 Jan 2026 00:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769734598; cv=none; b=WbZTA1J/Il0NvnQDUBYOiX1JOOLeite15zvyKwiARBcN26EynoVnKy8WGe7Lpf769d+foXhdKAIgTwsBAThPE05iSVQVGPJk+2FKu6f2soYOU+P/Emve0SQTp2YJQzjGDuV9RdvZVp45jYy422zDrTy+imNvv794YL+tHSDTjx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769734598; c=relaxed/simple; bh=yn8PL4p5L+Q0vwTA5XOCd1GObrfWBoMzr3UzU7TAx/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LVE0vo1M6dMEvWSMJwTfIFcTZ2UY842OVZIVB1ZioXQIF287jMrWiFwoa0KSC0SR0JeKNnM5l1kKawSBNAhNLrHZEbEeTxWRKIRZyBpzaPT8c0YIXw37MdH1D3oa52m7OO77/zrQIz69FORimoU8NUieAxF1FTuRJlcDJczW/1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.177]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4f2HdD0nsSzKHMSZ; Fri, 30 Jan 2026 08:56:16 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id E326540595; Fri, 30 Jan 2026 08:56:30 +0800 (CST) Received: from [10.67.111.176] (unknown [10.67.111.176]) by APP4 (Coremail) with SMTP id gCh0CgCHMvO9AXxpI8xhFg--.42470S2; Fri, 30 Jan 2026 08:56:30 +0800 (CST) Message-ID: <11d8ff97-74e5-440e-b56a-af590da5a3f6@huaweicloud.com> Date: Fri, 30 Jan 2026 08:56:28 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH/for-next 2/2] cgroup/cpuset: Introduce a new top level isolcpus_update_mutex To: Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Shuah Khan Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260128044251.1229702-1-longman@redhat.com> <20260128044251.1229702-3-longman@redhat.com> <08c3fad6-b881-4089-b081-bde6efbafbd2@huaweicloud.com> Content-Language: en-US From: Chen Ridong In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgCHMvO9AXxpI8xhFg--.42470S2 X-Coremail-Antispam: 1UD129KBjvJXoW3Jw13WF18JFWUWFyUtw1rXrb_yoW7ur43pr Z5KFWxtrWUtrykCw17tF1DXry8tw4UJ3WUJr1fJFy8JFW7Ar10vr40qFnY9FyUWrZ7Cr12 qF90g3y3Zr1UJw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS 14v26r4a6rW5MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWr XwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU0 s2-5UUUUU== X-CM-SenderInfo: hfkh02xlgr0w46kxt4xhlfz01xgou0bp/ On 2026/1/30 5:16, Waiman Long wrote: > On 1/29/26 3:01 AM, Chen Ridong wrote: >> >> On 2026/1/28 12:42, Waiman Long wrote: >>> The current cpuset partition code is able to dynamically update >>> the sched domains of a running system and the corresponding >>> HK_TYPE_DOMAIN housekeeping cpumask to perform what is essentally the >>> "isolcpus=domain,..." boot command line feature at run time. >>> >>> The housekeeping cpumask update requires flushing a number of different >>> workqueues which may not be safe with cpus_read_lock() held as the >>> workqueue flushing code may acquire cpus_read_lock() or acquiring locks >>> which have locking dependency with cpus_read_lock() down the chain. Below >>> is an example of such circular locking problem. >>> >>>    ====================================================== >>>    WARNING: possible circular locking dependency detected >>>    6.18.0-test+ #2 Tainted: G S >>>    ------------------------------------------------------ >>>    test_cpuset_prs/10971 is trying to acquire lock: >>>    ffff888112ba4958 ((wq_completion)sync_wq){+.+.}-{0:0}, at: >>> touch_wq_lockdep_map+0x7a/0x180 >>> >>>    but task is already holding lock: >>>    ffffffffae47f450 (cpuset_mutex){+.+.}-{4:4}, at: >>> cpuset_partition_write+0x85/0x130 >>> >>>    which lock already depends on the new lock. >>> >>>    the existing dependency chain (in reverse order) is: >>>    -> #4 (cpuset_mutex){+.+.}-{4:4}: >>>    -> #3 (cpu_hotplug_lock){++++}-{0:0}: >>>    -> #2 (rtnl_mutex){+.+.}-{4:4}: >>>    -> #1 ((work_completion)(&arg.work)){+.+.}-{0:0}: >>>    -> #0 ((wq_completion)sync_wq){+.+.}-{0:0}: >>> >>>    Chain exists of: >>>      (wq_completion)sync_wq --> cpu_hotplug_lock --> cpuset_mutex >>> >>>    5 locks held by test_cpuset_prs/10971: >>>     #0: ffff88816810e440 (sb_writers#7){.+.+}-{0:0}, at: ksys_write+0xf9/0x1d0 >>>     #1: ffff8891ab620890 (&of->mutex#2){+.+.}-{4:4}, at: >>> kernfs_fop_write_iter+0x260/0x5f0 >>>     #2: ffff8890a78b83e8 (kn->active#187){.+.+}-{0:0}, at: >>> kernfs_fop_write_iter+0x2b6/0x5f0 >>>     #3: ffffffffadf32900 (cpu_hotplug_lock){++++}-{0:0}, at: >>> cpuset_partition_write+0x77/0x130 >>>     #4: ffffffffae47f450 (cpuset_mutex){+.+.}-{4:4}, at: >>> cpuset_partition_write+0x85/0x130 >>> >>>    Call Trace: >>>     >>>       : >>>     touch_wq_lockdep_map+0x93/0x180 >>>     __flush_workqueue+0x111/0x10b0 >>>     housekeeping_update+0x12d/0x2d0 >>>     update_parent_effective_cpumask+0x595/0x2440 >>>     update_prstate+0x89d/0xce0 >>>     cpuset_partition_write+0xc5/0x130 >>>     cgroup_file_write+0x1a5/0x680 >>>     kernfs_fop_write_iter+0x3df/0x5f0 >>>     vfs_write+0x525/0xfd0 >>>     ksys_write+0xf9/0x1d0 >>>     do_syscall_64+0x95/0x520 >>>     entry_SYSCALL_64_after_hwframe+0x76/0x7e >>> >>> To avoid such a circular locking dependency problem, we have to >>> call housekeeping_update() without holding the cpus_read_lock() >>> and cpuset_mutex. One way to do that is to introduce a new top level >>> isolcpus_update_mutex which will be acquired first if the set of isolated >>> CPUs may have to be updated. This new isolcpus_update_mutex will provide >>> the need mutual exclusion without the need to hold cpus_read_lock(). >>> >>> As cpus_read_lock() is now no longer held when >>> tmigr_isolated_exclude_cpumask() is called, it needs to acquire it >>> directly. >>> >>> The lockdep_is_cpuset_held() is also updated to check the new >>> isolcpus_update_mutex. >>> >> I worry about the issue: >> >> CPU1                CPU2 >> rmdir >> css->ss->css_killed(css);            >> cpuset_css_killed >>                 __update_isolation_cpumasks >>                 cpuset_full_unlock >> css->flags |= CSS_DYING; >> css_clear_dir(css); >> ... >> // offline and free do not >> // get isolcpus_update_mutex >> cpuset_css_offline >> cpuset_css_free >>                 cpuset_full_lock >>                 ... >>                 // UAF? >> Hi, Longman, In this patch, I noticed that cpuset_css_offline and cpuset_css_free do not acquire the isolcpus_update_mutex. This could potentially lead to a UAF issue. > That is the reason why I add a new top-level isolcpus_update_mutex. > cpuset_css_killed() and the update_isolation_cpumasks()'s unlock/lock sequence > will have to acquire this isolcpus_update_mutex first. > However, simply adding isolcpus_update_mutex to cpuset_css_killed and update_isolation_cpumasks may not be sufficient. As I mentioned, the path that calls __update_isolation_cpumasks may first acquire isolcpus_update_mutex and cpuset_full_lock, but once cpuset_css_killed is completed, it will release the “full” lock and then attempt to reacquire it later. During this intermediate period, the cpuset may have already been freed, because cpuset_css_offline and cpuset_css_free do not currently acquire the isolcpus_update_mutex. > As long as all the possible paths (except CPU hotplug) that can call into > update_isolation_cpumasks() has acquired isolcpus_update_mutex, it will block > cpuset_css_killed() from completing. Note that I add a > "lockdep_assert_held(&isolcpus_update_mutex);" in update_isolation_cpumasks(). > -- Best regards, Ridong