From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828C51494CC for ; Mon, 20 Jan 2025 17:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737392953; cv=none; b=LwEr5K9fI0gI0P+p1jY/Fh29mtbP068rZrrzqT/zAJqHwjyL5xwW2AcltnsnSxfmjKahqHX9x3JHpfmYvwQjrIicOnZuESS7A/VGwdJ0UL+nJrDJGi+2RpaKaTpCe9ORlXoWXsoSnrmWwcyaNeJ0Oqym155mr8KoJ5h+klcSam8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737392953; c=relaxed/simple; bh=TQIUp0Ktz0/8SuM1izTKbnq6Cx9kjIoShb49g+Wbi/g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jaL+O9q8oZSfOikRylf/Ooc3KSgl2jcIBUVs41IAXPT43QjtAp+aotY5m7/Py1T0CQXBOeIb1xAGxl8SiqcUhfoZ2Y1IZ/2kX74D0FyZUacEEBv/KFhNA29ibQKRYIIIlpzgHtjurgvQNeLUi4q1D8FQvdb27sp/TB6NNdLej4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=glq0H7ZT; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="glq0H7ZT" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-aaee2c5ee6eso800388366b.1 for ; Mon, 20 Jan 2025 09:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737392950; x=1737997750; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=VTXrMPkz/viv10lA+MYrF5hM/FFmL7acbS2+Ve/WCnE=; b=glq0H7ZTMlTRI7p1yV2UhHCDe1UIdHQOyVycTQ+TNbMA+YR74CnBxYWhedAA2jEYQA r0JjidfHwcRFU2Ow+1FXZqiKzTsPe3RhCqXuXRaYUv8ApyyKmm1QH4We5bUr1ULU5mLE xnEA05tK8LSOvYjI2+wdn81qw6spvRJNT4E/D5XwA/3PeODrIJmuQTFmutgLRmwBrvzO O6Wy5ZxsS11sR68cpbaTH0TgpcudhVfNaA6L6JcJW9kc9jExFEmh2yA8jbrhHB17N4LD YvRS+vYS26O3HKCCQRiZUPYX8fa0XxtHiGBCupmTLfxemuUsogGNC4PJUtJFYGjdsxpq ZXZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737392950; x=1737997750; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VTXrMPkz/viv10lA+MYrF5hM/FFmL7acbS2+Ve/WCnE=; b=oztf62XworcE5bHN2a2b9s0KZNDeVMHI1jxFsMHxNWYcpwdoNRKMUkSeT7GiP9u3UP cItFKuUrIoqfNd2QcPvD2HIEWzPp9tyUmrJgdPGG+OnWuWrpT0AGhkbeg+4sSU3PCllQ zfjGsOYWwfEipQPdq/mCplYX5DhmxBSZBNzEBKd+X94FQ9z4K2BeYgt6rmrAo1kxDtiW 9Abk0OY8DR0uHONOBw1nxpyT+iluXQ9ImRxeUH7oJZ1X51JqLAI1ooZbPqGYsHSvTkC5 tgzUUtxSK1T4BXEF+4z2TieN7D3msluRF//WCFXBEUUapyMQvJKU6JiBvhKk2oJfsYn6 hhZg== X-Gm-Message-State: AOJu0YyW5S9XZjLU92E+YSTwyFCsfIC3toA0IUy4Q306KMwwgUHf7IcR JacsDimTDLQS7ddWs251eZ7pgYh7IQG6fsorjy9A/ziFp/iFHdaf X-Gm-Gg: ASbGncshOsMg43+HkUewWxhgX4KX30pbqvZ4CiVcKuPh0FoSEmOGM3ayek17cRUIc0S zDjjPBnJj097mzpdXh6VtrTyLOjdtLVA/P/rVuK0YT3w2ae3ATXmuRUO611J8W2Lw/ya1DxVlck tgA5yhNtxp5Svi3D6YxNfP0HhG4bdDp/CtqE7oi8gZONQKHKiehbCAAXh5Fi5NEoWFkDjwSbQv9 s4bjN6rY218SmbE5xFv1l6giMPkjxYZu3c1rjoGOLtMtLYyaaQ0O0Zx2Jd+zMV8s+502skSjTMu zRha5IY= X-Google-Smtp-Source: AGHT+IEo3SK+yXDK1MNDKBrxpBhe4pyGECizWv6wccSdRBMrNEpCF0M8a8IB51BoPMmPsDySvZ0eNg== X-Received: by 2002:a17:907:c15:b0:aa6:9624:78f7 with SMTP id a640c23a62f3a-ab38b112933mr1246662766b.17.1737392949455; Mon, 20 Jan 2025 09:09:09 -0800 (PST) Received: from [132.68.46.60] ([132.68.46.60]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384c5c3e1sm637057966b.7.2025.01.20.09.09.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 09:09:08 -0800 (PST) Message-ID: <11d9f41a-eae3-43a1-90bc-eb5c69020002@gmail.com> Date: Mon, 20 Jan 2025 19:09:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/12] x86,tlb: do targeted broadcast flushing from tlbbatch code To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com References: <20250116023127.1531583-1-riel@surriel.com> <20250116023127.1531583-11-riel@surriel.com> <13bc0c49-09a4-434e-bd35-1ea50be38e25@gmail.com> <4dcf2b4ecaede883e2c7f6af3db58a4f6afaf4ad.camel@surriel.com> <2975f6a4-58ef-4499-b177-4b73ead4c670@gmail.com> <2c93b3f17e658483e3ea03ca3f0a717668fd117d.camel@surriel.com> Content-Language: en-US From: Nadav Amit Autocrypt: addr=nadav.amit@gmail.com; keydata= xsFNBF3nSCQBEACinGNWCLb3Iptvg066zPUQCFfR0nIX+j/pjxlLd094zOKLJ7Z1wKNNTQgb +Y1GQYwKurK1hFHISPc1T7xk2twzov5niFqQp1/E0I6t/92rxo7C26tKMrCHgqXpFXXBaOvq t0QN8B83o3sfS3OZyc0F5hWoJijhKQ+h7dJHMPpBBeTWiZzYVlMNz/wRzYrh1nvesbGJtV1w Wk96qoQAOagczRaSRWouJ1O2JbHqQarLJG657hqtPZctQ1mkXQcJedT1c8ejWBdIiU0rIpV/ R2uTgM5NSjVrY5OxiS2G4C/bDcI4Q6ApWxqu1zRGffKWRFJdQvttSv+JbW2q6OCvJReJs1i6 nTovpfJb3g9d7U76LtAw7HE5iIl5CmyFoTMMH+sDc5PG7JRboiofku9DWeDGK4rB2s97GuA9 BXJDHBbH1AI+Y0H6oz/Dri1sQSayUU8Xj/jCkwxpwDle1qYYE0UM4PqDTUoeejURR/h/AREt bCecfxNUYNz2jY8PUL0YXj6yex2p1otMy5sy7djrTqhC02AXLQ3Oab2UJuMZnf4cTbN2sGXu CRXcCSsoyhxIFtwpgdVIDqkPMCOEPvUwy9hWs0N9Xy+jOebpH6FYxq83pP3IhyBdaoexoyGL IkSzrO4+0bVk5voh5SIYVkLEooMSEQT9rfSdrJmRRuM7S/PowwARAQABzSFOYWRhdiBBbWl0 IDxuYWRhdi5hbWl0QGdtYWlsLmNvbT7CwZcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQRIkveiyXlibH/D0jUdoCpJptoPWgUCZWMLXAUJCz4qOAAKCRAdoCpJptoP WoWjD/0d8I+qQIHp2Eq7Whi+idkGDJaaBksRw2r0+XTzRj0CsCFJS7oMWudQaYaI2bTW9uha zfcmpnkm5aOVoxGOGJUJSy0H4of6lShE+7caoz1pdX+y15STij3+RvUjcGn0N+Mpxrnj6anm ArH5KOwzQJDiMF48ntQ2EQAFJ5X6YZ6Ed9N4I88XPeOtWaU21Q5tZI/ASHrQTH7BMukkVe2U PkSjn205vbrCfcC4Ohu9HXC8ey6l5txomFaTIRvaz1La3W8gQHhT2D2QeNnJFRudN5hQJNIE OHFi6QmPVIbI/uYD82h5uesiufycV2kvuIACmvs2T3tpaxSY9HOJF/yAhqg28hKE4wKQIwh2 wzZ+ywDeZ5TboqTjTU9oPHuRTxYItWmevJgQDwOYcssYI4wOdXvu/bh5VvhBgJxgkOOH7j8N efzqooL/2/pD/1JAO9GjPEWbuRx0dZh5tcMq/RYFFhdZQNFYmqdDyY0+y6ntxEo25ScvVLfR GqhpyJkN9+cqJZfg3IolbWoZxkSLtiCBge/EDRRoLJpjpsLpBmMmQcH/50WgQcoL5ObVlc1I ft1sKfzZvIyqXZfu3YcWgvOXfVXaMw1dXQ8ffwgyCSIsKvA5+Y45knd72SHny5z3gi1YsMc1 lm24v+OfxfmZMmJQ7TXBDl0JkOMnQ3A+KDb0oGAI6c7BTQRd50gkARAAt/NqfDSMph828JIn VOck27zsyT12AHRLIhsCCatw+zYbdMSLTW6hd/sChStdndAQlqOOW3mpm6bA+jl59c4OhkBW 8fDKgaWjVq8kBm4Z61zhzk3oXMmxgQ3cqMEfN36PCpcfs5MtLiMoa2JxaqFMQbKkmcZqz8fw qGIID/SMI5qdk+yWZSmR+6RdzXfppEIeqs78qTFxaEl+0MlAcgo2AjrMPLIjNK3k4jNAVCix KjMfkkPk6xVmP5Q7cr1st0xTTa1APt0y966oa6CZIdHY76D/jLpjJlfalctmEAxmyBqK0ZkK WDkEF+qCqqZ7oSkC1Q0ogBuBffIZb5srleqMz++IutiE4r/LELs7RanXXCRK5JYzZc/uAnxN fCJzqKR5/JxoSnCh0yQNU4FHa78DeD/SLnCu8JwTGkcX9ZUW/ZQ+5Nsimy+SlZb0UyaWA+vr Q7+F7OAL6PFsE8v+Q2u2EHwa8e2KmsL0sC+enBXbaogLFFfKi4I13vOk+76nCZTNetRhAubM etLe1PZZ0IDzgGhjFg+cc/jptq3qYjK+3jzhdKaqmoibAoea3E/5HsTVVbxUiYEdk2crTqf9 Mr5S5AzQfH19xU7uUduBvjN3L0dRKP0wJEqgCIB5gZBjD8AYmKSgdEujDAPQNXTJgwB99C+r F0XoHEmO6m9vI6djzDsAEQEAAcLBfAQYAQgAJgIbDBYhBEiS96LJeWJsf8PSNR2gKkmm2g9a BQJlYwtcBQkLPio4AAoJEB2gKkmm2g9ah7wP/jP18+dznONUt3Nga6XKYxxlVmVnMlqHx6SB jDWTwFzcQ6UeVVUmODWBSLI+iqg5djkgsTcHwI668qhIyyWaXC9ld+ONhUaE4NH1PKcJ8cdG vzhdTG8lM9mwmnJriTfih59OLI2yKpml/et44gvsfQpmFOyrdH9u6xPai5h3KyOoXD+Q3EzQ KEiHqs2x0PX72Jz4iVKEanP+qxEwzarUUcum94ecGilYY4jfxhfkgwBWjmC7ExbVTSEKIx3Q zdDbDiAxhAWymSisP3lbYqRo8mkg8r2emNan5L5Xh1b/62zmMO+p6gzucV7vO0VJxlKuUkFW 77Ug+X+hkDedvp2oRBz+wKtBxwSxlTM4toD49Jn111OMS6R5opquZP+/SJH1njSKY9MY3D3D 57QDpRUvqbqMDdqZqmYlMxntxTJ+0yksR61/t62F/bSp4XLxbgwCXMm73TxGrU73ngaS/Nxz Pv28VEcCGXZqFS2sbsbBSEjGgPhXf73YlI1fYiAFiaKHKvlofX+xNLeRHr9/+fL4JWPFurGi WYMyVA5Fv1sfefXhdEv9qNlhyNHxxB3vEpxkEOdo0JUhNfIcxe/w5iOfCUAtwUfvijvHUFHh U5QeQckJZTApjJ4S/Wa1ef8eS/LBsvG9xMNG3Ns+M+xR6unu6gTuzUNp7Zsxgmp8hs0racLB In-Reply-To: <2c93b3f17e658483e3ea03ca3f0a717668fd117d.camel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/01/2025 18:11, Rik van Riel wrote: > On Mon, 2025-01-20 at 16:14 +0200, Nadav Amit wrote: >> >> I am not sure we are on the same page. What I suggested is: >> >> 1. arch_tlbbatch_flush() would still do tlbsync() >> 2. No migrate_enable() in arch_tlbbatch_flush() >> 3. No migrate_disable() in arch_tlbbatch_add_pending() >> 4. arch_tlbbatch_add_pending() sets >> cpu_tlbstate.pending_tlb_broadcast >> 5. switch_mm_irqs_off() checks cpu_tlbstate.pending_tlb_broadcast and >> if >> it is set performs tlbsync and clears it. >> > How does that synchronize the page freeing (from page > reclaim) with the TLBSYNCs? > > What guarantees that the page reclaim path won't free > the pages until after TLBSYNC has completed on the CPUs > that kicked off asynchronous flushes with INVPLGB? [ you make me lose my confidence, although I see nothing wrong ] Freeing the pages must be done after the TLBSYNC. I did not imply it needs to be changed. The page freeing (and reclaim) path is only initiated after arch_tlbbatch_flush() is completed. If no migration is initiated, since we did not remove any tlbsync, it should be fine. If migration was initiated, and some invlpgb's were already initiated, then we need for correctness to initiate tlbsync before the task might be scheduled on another core. That's exactly why adding tlbsync to switch_mm_irqs_off() is needed in such a case.