From: Baokun Li <libaokun1@huawei.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Alexander Mikhalitsyn" <aleksandr.mikhalitsyn@canonical.com>,
tytso@mit.edu, stable@vger.kernel.org,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Stéphane Graber" <stgraber@stgraber.org>,
"Christian Brauner" <brauner@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org,
"Wesley Hershberger" <wesley.hershberger@canonical.com>,
"Yang Erkun" <yangerkun@huawei.com>, "Jan Kara" <jack@suse.cz>,
"Baokun Li" <libaokun1@huawei.com>
Subject: Re: [PATCH 1/1] ext4: fix crash on BUG_ON in ext4_alloc_group_tables
Date: Fri, 27 Sep 2024 09:51:58 +0800 [thread overview]
Message-ID: <11e3133e-6069-477f-9c4a-3698bd6a18ec@huawei.com> (raw)
In-Reply-To: <7521d6a5-eb58-4418-8c2a-a9950d8faf9c@sandeen.net>
On 2024/9/27 0:29, Eric Sandeen wrote:
> On 9/26/24 11:04 AM, Eric Sandeen wrote:
>
>
>> Can you explain what the 2 cases under
>>
>> /* Avoid allocating large 'groups' array if not needed */
>>
>> are doing? I *think* the first 'if' is trying not to over-allocate for the last
>> batch of block groups that get added during a resize. What is the "else if" case
>> doing?
> (or maybe I had that backwards)
>
> Incidentally, the offending commit that this fixes (665d3e0af4d35ac) got turned
> into CVE-2023-52622, so it's quite likely that distros have backported the broken
> commit as part of the CVE game.
The commit to fix CVE-2023-52622 is commit 5d1935ac02ca5a
("ext4: avoid online resizing failures due to oversized flex bg").
This commit does not address the off by one issue above.
>
> So the followup fix looks a bit urgent to me.
>
> -Eric
Okay, I'll send out the fix patch today.
Regards,
Baokun
.
next prev parent reply other threads:[~2024-09-27 1:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 14:33 [PATCH 0/1] " Alexander Mikhalitsyn
2024-09-25 14:33 ` [PATCH 1/1] " Alexander Mikhalitsyn
2024-09-25 15:57 ` Jan Kara
2024-09-25 16:17 ` Aleksandr Mikhalitsyn
2024-09-26 8:50 ` Baokun Li
2024-09-26 9:23 ` Aleksandr Mikhalitsyn
2024-09-26 9:40 ` Baokun Li
2024-09-26 11:32 ` Aleksandr Mikhalitsyn
2024-09-26 13:58 ` Baokun Li
2024-09-26 14:19 ` Aleksandr Mikhalitsyn
2024-09-26 14:35 ` Baokun Li
2024-09-26 8:28 ` Baokun Li
2024-09-26 9:16 ` Aleksandr Mikhalitsyn
2024-09-26 9:28 ` Baokun Li
2024-09-26 16:04 ` Eric Sandeen
2024-09-26 16:29 ` Eric Sandeen
2024-09-27 1:51 ` Baokun Li [this message]
2024-09-27 2:39 ` Eric Sandeen
2024-09-27 1:43 ` Baokun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e3133e-6069-477f-9c4a-3698bd6a18ec@huawei.com \
--to=libaokun1@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=aleksandr.mikhalitsyn@canonical.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=stable@vger.kernel.org \
--cc=stgraber@stgraber.org \
--cc=tytso@mit.edu \
--cc=wesley.hershberger@canonical.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®