From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFB7D37CD5C for ; Sun, 31 May 2026 13:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780233455; cv=none; b=DZZCXZEZTZ/PzqEgZlSsbQ3EVgliNpK2KxscUyEqE/yOwWjlvZO+YUXGMd7qIt3rA2crJmbG2zCwngSh4tKic2rO2hITCzyEmh2L0OPhllvGndslndik05Vc+wosmUuulq7D7J8szh8KZZSpLK+YCC7lJcRRq5tfRqAUEGXcPwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780233455; c=relaxed/simple; bh=HqKK9fAdRh/IQ2TWJzLWCRQlPaWhvT3nlw3fHwZbF4s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NkM3LQ+WRifshdVR2lPfW+MtzaA7ly/ylb1/nz9U2v6bzK7Wg7mrJeBFnqyHv6/KMB9WMUBq+cGQIb1f4hlNog9oB5QLuKcU/D9brcqTjktsT0VsXmeasUjp1rnJLNOF/hSG8jxiKMXDPUQ+t6GDgZ6Dyzif2/+Ymb8rGm1CZHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e/7ESWWx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e/7ESWWx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5ED61F00898; Sun, 31 May 2026 13:17:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780233454; bh=TgK3o33LQKPM1WDdIyiHkK6bLsiY8RdbftsC17rVWmg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=e/7ESWWxcrAR+s+EGYHS9UoUj4lwkMKq41hno2mRHVN0amaHTG8h46Y43OpSu0+YF pCsLBzOuawYbfW7EdDy+QCWwbM/yJ4UUyn3D3v/QpuYeZDGnrPfkc1bXU9lbmXb6ZQ k1y92hL2KLCRYuX8kJx83OqrEjisIetlCxg0pk3JcANIkLGT8omEFmmcqnd7mxOnzb 2AUyEgCcL85e043JPQV2ufWaGdMrq7p+W8ujf1i4BTDSxgfHGloKy24iYtk0l6Tgwl Q44NM5gJ7BpYmpsIxzkXRnLkLCS7pnJNBYKPkNqnWQa0kHkOMncfVUapCX5SLsnWIA Y1L9ziXb4Wc8g== Message-ID: <11e636a3-8338-4f87-8519-1b38af62a00f@kernel.org> Date: Sun, 31 May 2026 15:17:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1] accel/amdxdna: Return errors for failed debug BO commands Content-Language: en-US To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, karol.wachowski@linux.intel.com Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260529162122.1976376-1-lizhi.hou@amd.com> From: Mario Limonciello In-Reply-To: <20260529162122.1976376-1-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/29/26 18:21, Lizhi Hou wrote: > The config and sync debug BO commands currently may report success even > when the operation fails. > > Capture the firmware return status and propagate the corresponding error > to userspace. > > Fixes: 7ea046838021 ("accel/amdxdna: Support firmware debug buffer") > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/aie2_ctx.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c > index 2ad343728782..da89b3701f5b 100644 > --- a/drivers/accel/amdxdna/aie2_ctx.c > +++ b/drivers/accel/amdxdna/aie2_ctx.c > @@ -305,17 +305,13 @@ aie2_sched_drvcmd_resp_handler(void *handle, void __iomem *data, size_t size) > struct amdxdna_sched_job *job = handle; > int ret = 0; > > - if (unlikely(!data)) > - goto out; > - > - if (unlikely(size != sizeof(u32))) { > + if (unlikely(!data || size != sizeof(u32))) { > + job->drv_cmd->result = U32_MAX; > ret = -EINVAL; > - goto out; > + } else { > + job->drv_cmd->result = readl(data); > } > > - job->drv_cmd->result = readl(data); > - > -out: > aie2_sched_notify(job); > return ret; > } > @@ -940,6 +936,7 @@ static int aie2_hwctx_cfg_debug_bo(struct amdxdna_hwctx *hwctx, u32 bo_hdl, > aie2_cmd_wait(hwctx, seq); > if (cmd.result) { > XDNA_ERR(xdna, "Response failure 0x%x", cmd.result); > + ret = -EINVAL; > goto put_obj; > } >