From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 0/4] Add support for constant power-supply property tables
Date: Tue, 14 Apr 2020 17:55:32 +0200 [thread overview]
Message-ID: <11e73f71-56f7-328a-ed4d-a4e393ba7265@collabora.com> (raw)
In-Reply-To: <20200413183853.1088823-1-sebastian.reichel@collabora.com>
Hi Sebastian,
I went through all the patches and Anyway I also tested with cros-usbpd-driver
and they look good to me. I am wondering if you shouldn't constify the users in
this series too, looks pretty trivial?
Cheers,
Enric
On 13/4/20 20:38, Sebastian Reichel wrote:
> Hi,
>
> This marks the properties and usb_types entries in
> struct power_supply_desc as const, so that drivers
> can constify those tables.
>
> -- Sebastian
>
> Sebastian Reichel (4):
> power: supply: core: Constify usb_types
> power: supply: charger-manager: Prepare for const properties
> power: supply: generic-adc-battery: Prepare for const properties
> power: supply: core: Constify properties
>
> drivers/power/supply/charger-manager.c | 40 ++++++++++++----------
> drivers/power/supply/generic-adc-battery.c | 22 ++++++------
> drivers/power/supply/power_supply_sysfs.c | 2 +-
> include/linux/power_supply.h | 4 +--
> 4 files changed, 36 insertions(+), 32 deletions(-)
>
next prev parent reply other threads:[~2020-04-14 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 18:38 Sebastian Reichel
2020-04-13 18:38 ` [PATCH 1/4] power: supply: core: Constify usb_types Sebastian Reichel
2020-04-14 15:56 ` Enric Balletbo i Serra
2020-04-13 18:38 ` [PATCH 2/4] power: supply: charger-manager: Prepare for const properties Sebastian Reichel
2020-04-13 18:38 ` [PATCH 3/4] power: supply: generic-adc-battery: " Sebastian Reichel
2020-04-14 15:57 ` Enric Balletbo i Serra
2020-04-13 18:38 ` [PATCH 4/4] power: supply: core: Constify properties Sebastian Reichel
2020-04-14 15:57 ` Enric Balletbo i Serra
2020-04-14 15:55 ` Enric Balletbo i Serra [this message]
2020-05-01 15:10 ` [PATCH 0/4] Add support for constant power-supply property tables Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e73f71-56f7-328a-ed4d-a4e393ba7265@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®