From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0816EC7EE2F for ; Fri, 3 Mar 2023 08:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjCCIsE (ORCPT ); Fri, 3 Mar 2023 03:48:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbjCCIsC (ORCPT ); Fri, 3 Mar 2023 03:48:02 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ABC4EC49 for ; Fri, 3 Mar 2023 00:48:01 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id u9so7460418edd.2 for ; Fri, 03 Mar 2023 00:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677833277; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1o8Z6knbD9JeBO0oaE7g0z7HQCbcSRqmQSyWUB8EgVs=; b=PXVdQZGWAli4fKq44IVxwmlxQcwpcO3r4t33vEicvy4ceXFxc0FjR8vTSzZt+6oNfM oP/mjd5H563yfZRNXJ+cXxZfVe4TegFWPegJ+puEouxeoeoUiiu4k0lJmRMciczqZev7 uyOzA/fKZ5JSjmYY5mb6XpSrBnQaCIft2/fE/0ZlSnnPSA0TAD7jwG4at18gSarfzQYl 13JDvE9nAuSjw9Szc1LgVfPTmulReZOnaBWJflmJPMbUZ8spFEo/MBAgKSGQZ7csufzY ncUPRxlcv9x16xn6dl2lFcBpB9WxsogEQ2WdXslKc2HaXVh6MuPIYN22X5MpgcSjWsHH CwqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677833277; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1o8Z6knbD9JeBO0oaE7g0z7HQCbcSRqmQSyWUB8EgVs=; b=h7LPRR2FSHtVpbOe5nkAdBfNfuM9HWKA3CqxyGfxdgqH8V5iY2Ne39NBPTNits8pdL kdziMcYuhGVo8/0SSUl2Wto6gm7p/bKd3gx0lQLxQKbGlBE1FQ7CbwLD5Bk2JiDbZFwA kLUiyIWcBAVHfzNDTXHRBacN/D1BtSO37FXXYL1l6p5M1PUWeKLjDsS2dwEPHRLnbOWz w43fzrK61w7VnotGCaFkG4Cn3KgjJco/x1mZIjr2eCuMEMFL09yphOauNcjRrSL2aoSQ kUwsk1RLnVMyauFQC5ChKPTiA3l+csQKNSknshPFsKKDFeif4zr0IDBx0LOkrvl72Np1 Q3nA== X-Gm-Message-State: AO0yUKU34bW+uObWYnMLfTUNxNm7pfzbjchZj6Yx4KDUaPVmolJVAsyG 2ZL0/UfTELzoaHfVam7xoT6rEA== X-Google-Smtp-Source: AK7set+r4Cvg3dl/xH9EUbRtdz8piEI7wRJtm+cjqTrkuGuTCIVx8rB5BT/XjGCoUkgTr3cQlUa70g== X-Received: by 2002:a17:907:7604:b0:8de:e66a:ece9 with SMTP id jx4-20020a170907760400b008dee66aece9mr838215ejc.24.1677833277235; Fri, 03 Mar 2023 00:47:57 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id gq11-20020a170906e24b00b008dd2db45c0bsm704839ejb.105.2023.03.03.00.47.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 00:47:56 -0800 (PST) Message-ID: <11e7c986-e6cc-ee57-b36e-816af8cc11a7@linaro.org> Date: Fri, 3 Mar 2023 09:47:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2: add binding docmuent Content-Language: en-US To: "jack.zhu" , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Maxime Ripard , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, changhuang.liang@starfivetech.com References: <20230302091921.43309-1-jack.zhu@starfivetech.com> <20230302091921.43309-3-jack.zhu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230302091921.43309-3-jack.zhu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/03/2023 10:19, jack.zhu wrote: > Add DT binding document for Starfive MIPI CSI2 receiver Ehh... you have entire commit msg to explain what you do here. Yet there is nothing mentioning that you actually have Cadence MIPI CSI here. Since you decided to add new bindings, you receive review matching new bindings. I don't think this is correct approach (duplicated bindings), but could work for me. However how are you going to solve all the points of my review? Best regards, Krzysztof