From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB3D2C433F5 for ; Thu, 17 Mar 2022 12:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233595AbiCQMdk (ORCPT ); Thu, 17 Mar 2022 08:33:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233401AbiCQMdh (ORCPT ); Thu, 17 Mar 2022 08:33:37 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7C271DDFCB for ; Thu, 17 Mar 2022 05:32:21 -0700 (PDT) X-UUID: 6ccc6fa715a148709feb0513544d145e-20220317 X-UUID: 6ccc6fa715a148709feb0513544d145e-20220317 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1120966402; Thu, 17 Mar 2022 20:32:16 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 17 Mar 2022 20:32:15 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Mar 2022 20:32:14 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 17 Mar 2022 20:32:14 +0800 Message-ID: <11e9d1dbd49a298116a50b8d94faeef5046c97d5.camel@mediatek.com> Subject: Re: [PATCH v3,3/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c From: Rex-BC Chen To: , , , , , , CC: , , , , , , Date: Thu, 17 Mar 2022 20:32:14 +0800 In-Reply-To: <1647408934-15775-4-git-send-email-xinlei.lee@mediatek.com> References: <1647408934-15775-1-git-send-email-xinlei.lee@mediatek.com> <1647408934-15775-4-git-send-email-xinlei.lee@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-03-16 at 13:35 +0800, xinlei.lee@mediatek.com wrote: > From: Xinlei Lee > > Add the compatible because use different cmdq addresses in mt8186. > > Signed-off-by: Xinlei Lee > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Rex-BC Chen > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index bced4c7d668e..8c61c4f412bc 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1140,6 +1140,12 @@ static const struct mtk_dsi_driver_data > mt8183_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1147,6 +1153,8 @@ static const struct of_device_id > mtk_dsi_of_match[] = { > .data = &mt8173_dsi_driver_data }, > { .compatible = "mediatek,mt8183-dsi", > .data = &mt8183_dsi_driver_data }, > + { .compatible = "mediatek,mt8186-dsi", > + .data = &mt8186_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);