From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851AbdHRMvT (ORCPT ); Fri, 18 Aug 2017 08:51:19 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:43030 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdHRMvP (ORCPT ); Fri, 18 Aug 2017 08:51:15 -0400 Subject: Re: [PATCH net-next] tcp: export drops counter to /proc/net/tcp{,6} To: Eric Dumazet CC: , Jeethu Rao , "David S . Miller" , Alexei Starovoitov , Eric Dumazet , , References: <20170818102135.266832-1-sgorget@fb.com> <1503058444.4936.169.camel@edumazet-glaptop3.roam.corp.google.com> From: =?UTF-8?Q?St=c3=a9phan_Gorget?= Message-ID: <11f30e3f-b08f-373e-b952-4a5bdedc3e7d@fb.com> Date: Fri, 18 Aug 2017 13:50:50 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503058444.4936.169.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c092:200::1:35ee] X-ClientProxiedBy: AM5P190CA0006.EURP190.PROD.OUTLOOK.COM (10.161.47.147) To DM5PR15MB1292.namprd15.prod.outlook.com (10.173.209.150) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aacd8773-7296-4334-3eed-08d4e637ca9b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR15MB1292; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1292;3:Z63g/wgZWq0k1PFKLnZ58yCNQF+/nRpqroGxZ6mM9imzr8SqD00ggZdsMKE8zl+PbQsGpv6QW6h6Pufupucx7p6cfAJ/7swG8KdzICWjs6+PSFa60Sbc3CgYiNPTTXgNcN8P9oWC/t5ACdLUXdol/vbm9vXWVn+1Wm2pmeQ2j1nk3p0KAsvp10nPu1SIrXYHOXu85c5yVRtkg57pTi2BR0aSYAmDdisB6RCtDcQAIAZE/VaMYt/W+FlYF53iStAI;25:T7TdRkJ4Wb8aARPwjtfO1KEZYaAxnh3aftF1JZqdqUUzgxYmtgdGjdLjvS6+useGKI0ErD4+N7EXXqiAXLjcEgiQA+32IAA+Sl+zePlmGWUp4+g5fXCc6lSPMu6LoqfQ3KMbBQFyZ19iArOjF2rPMMlxGjBEX+jltkRCnPzpNtqI/kEF/NyqDSkQ8B81iE2jldE7smc6YSvUi5U2jmy8MsCiyVltEWJtF/56jLPauEuSjCX3uTRXNuttNsLv87/9Mba/FZjDRw/Ngmklw5XkvR5BUpzejLtb/89FpV9BSJXm3nOKX+W26xXnuzXjgetzv8qhgH6CbR0NBx5b6Ac85w==;31:bS/FHqi4t+yZoqajJ7bC/7X7pUm90n3c5KWZQ6rNu9mUfDa9gmjYIPxfRGtyFoAv+9/YKllU29C3Ve2yRjKrkRfI7xn5ce1q20D5+tau4fcpHpSq5PBVHNwRnb+O4+gw+pc3qxhHibrbx2u0LCmH7jG/2S/ICR4pCFmq7rYTbjNcGsa+toZrBjd/qQKi3A5QkjvT10rADgWuj9TAZacDVscqtsMEcwBevUqFHwhpl88= X-MS-TrafficTypeDiagnostic: DM5PR15MB1292: X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1292;20:+7S7Qm4LeAWyHWnu033d2CDgxcr77x6Iu6rBn0uIBkpUZd4GGNl5i+nOJ8I0HDUNonyWV21E/7dCAvYpBDx6yR5qQy+mEMeQepfOybxFqxhbIRjO4CEwzTPMDsYUXQM6Md+xiUKi7qqJfmZA1oetrt9S3ebGR7JPc2icbqz8nLa/ygLT1culi8YIqoxej/oVd9uD9hNod4VmxRBBGOmTX/4jhqwAydNmLCo4h4JhklZA0ReGZlUlHy5R/MdTQta+NARnZZqvLSvGRMoaZDbXVybzIwg8AcF4fjlfdrLJl+LvzJlLjSjvJqGBdOfq7Z0OOpmatTkYV8V/RNYwNXWO57ay1of0pk/KLzEsTQjTz3kt9CExJL0gftLcl5uQ3gY8N2dTPbzUjW/zVr4mObVsH8ENVE8XiljCafNXpEwbeghjuRD2iwGwrenOXaT7QhjIRqRhz5rSsbkxejH79NI7+F+5QoEqI5DAIIAxp5IadUTT0o5KNQihtWaB0bkbupNa;4:vy1XielbZIyvIMSZiwRtYlWd+v61seRgJ9ZeJDe6Fez4L+XoWKC/pqUJByb34qSOcT/4LFWKJb9AgIjthNLWiPx8fCSh/2A/x7zbo+obnYKvzALc/k6/xO8AHEyjhQEDw0rQXyY5hn3mkfNaROgNODQNNXBgbErnowse57TTr3KVJK1mZGdeE1XzR0mjDldH9frr0iFhuRVD6kImJZHLXou5bZWR2aHD+giTLpFOwYoMBOM4ZFI4/ukEQY/25GtA X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR15MB1292;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR15MB1292; X-Forefront-PRVS: 040359335D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(7370300001)(4630300001)(6009001)(189002)(377424004)(199003)(377454003)(24454002)(51914003)(53546010)(97736004)(478600001)(189998001)(36756003)(7736002)(65826007)(5660300001)(33646002)(2870700001)(42186005)(86362001)(31696002)(4326008)(25786009)(2906002)(50986999)(76176999)(101416001)(54356999)(47776003)(64126003)(65956001)(65806001)(31686004)(23676002)(81166006)(7350300001)(81156014)(8676002)(50466002)(83506001)(105586002)(6666003)(53936002)(305945005)(106356001)(6512007)(2950100002)(229853002)(6506006)(110136004)(4001350100001)(6916009)(6116002)(6246003)(68736007)(6486002)(54906002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1292;H:sgorget-mba.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMjkyOzIzOldUYVppUFl0WFl6Y0tXc3B3RUtoNUIxSjFw?= =?utf-8?B?SlZhUHlLRFRWcSsyQTRzWlpxLytSNURQdnA4N0JnK0ViL1pkV1pkRlBSaG9M?= =?utf-8?B?V1AzUVdFczVCWUhqK1F2U2FJdE5iU2dpb1FkT01lWTA5ZUxhZk1NRnpNVCs3?= =?utf-8?B?V09Ob2VlLzlWcHk3UXhaeDUwNXdVWnV4VEVWVFdVYi90UWU0Zm9DQmg0K2k0?= =?utf-8?B?TktmRnoyMUZZL1NWbFFqaWZjWUJoczNLK2hnL1RybVh0OVRQcVNFU2dPKytJ?= =?utf-8?B?d0REYUVhbnhta0d5OHZ5OStLdkNzbUZWeGVETGQwczdYU0M0ZmZwMCtDZEhq?= =?utf-8?B?NzFTQmNxalA5QXNXbG5oSVh4S0hENXFNV242Q0NldWF6YXlGMEZJUmI2K1lC?= =?utf-8?B?b1ZBSHBYaVRiZE96ZUxDZ01xTE9RU1BYY2Z4bGhvUlQwSERWbXJQMHplMnVq?= =?utf-8?B?RHBidG1BOFc3bWhEdHhmT04zazVTQmc4S0hkVytCWDlWV09Cb0ZBRXEzSHdl?= =?utf-8?B?QTl4dy9nRFdvVjREZW1jQnB3VGR1Q2xXSmx0andEMjhFbHNmTTNsL3JWVWhJ?= =?utf-8?B?RFpnVUVCbmdrQUJQeWZTTnVXT3B2Y3NxcUNxdGhWOVRyUEZFUmQxSFNPZG15?= =?utf-8?B?MWdsNUpDZnlyWFNwcmFLaXJKNXRvSFJHMjAveUFoUHFMVzhPajRPN1B6VGg4?= =?utf-8?B?cUkwczZtdm81SDUrTUx1ZGloYVllM2xrN2dWNlpZQjNYaTBJUjBVUHV4c1Er?= =?utf-8?B?OU05Sm9JZTE1UCtCMVhrMnhWaEU2ZXE3VUFQaHk4ZVAyMENXQVJMNnhUZEVy?= =?utf-8?B?S1dkbElYRTlyVVIxRVR2WlQrVEJ2eVY3YkwvTU1RQ01lSVJiZlhXY0R6cFN2?= =?utf-8?B?Yk0zUFMvZEgxdUZaeTJUWmFoaVBhRzBiVExmTXlDUEhHMG8rQnQyOTEwV1k3?= =?utf-8?B?UjVFdy9kUzlqckRpS2plWW03NlpVZWl0bTZHU3N6OUlwY1g0a3NuOHl5NjUz?= =?utf-8?B?RTJQNTFMSENuc2pqK1FYU1JUdTRMY09Tb2tTOEpYT1UzUHVMMTF4R1IxVUc2?= =?utf-8?B?aUllVEtncG5jWVBOUlRZNExpcjVVTXdpd3FaSFVUZjdkVTdkQnAvc0prclhv?= =?utf-8?B?bHpHamRuS2d1cVFwK2VkTkVobGNQWEpjNkpzUzRKNmZmSng5U01DUi9meDl1?= =?utf-8?B?RHpTN2VNYmhLQ2FIQldHbWZvdm1uKzl2UWM1dFhYd29Tak91RmN0MjJKYlFs?= =?utf-8?B?UVIzU012enZpRXpXOXdOLzlYdUVtcTU4ajB0OFo2b0RYcFc1R25FaXowdG03?= =?utf-8?B?KzZRRXA1bHpvajlXMnBzcEw1MUU5TzRJOElXNjZEaDFGc3R4UEgvNjhtRUhU?= =?utf-8?B?RkFJQWsvcnlzZjdhZmgzcisyd2ltbTdGVlZxTGIxdHB0WmVlMUR3d291ZnJ1?= =?utf-8?B?S0hnUkFwMUs5cVRCRDdTbkhJbFhQVWxVRDZoSEd4enRyOGlQUGMrRlk1eXI3?= =?utf-8?B?cm11N3NDU0NSdldNbVg5clM1V2l3WlFWNzhEYVJXc2t3NkhYRUdia1JpeEl0?= =?utf-8?B?THhQRFpkTXJ4Q0dWM1lCNDRHV00wc0hHKytSQTR1eVdpNm1HYW9yc3pGM1oz?= =?utf-8?B?UGptZkF0WVJ5TFpET1MyaElERWlaUUZ2bUVqbEN0eUI0U2w5ZmI2cDFEdnJH?= =?utf-8?B?OHpxU1BpQnN6MnNYSGVvUU9vMlVUL3pMOTN4bWhZSXFueWhIcmdQMmhPUGRN?= =?utf-8?B?eG9tMFRQK1JrSlVvN1Y3dHFPVk94dmRNeXBXcVFoSURFbFhhWEd1VkNJZ2gx?= =?utf-8?B?bUNSeEJYa2RhWk5RWDVqSVVhcUk2ZElUNTJoaFBnaEVreHdsQjFJaTM5N2Zy?= =?utf-8?Q?Q7lyjR7V8bxb4F+wJlOoj80t9XLHwsg2?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1292;6:57sFzCplBxaSlBplK+jc6o94tdiTWRTK7fTw9aGf7lZG4GrJGCNHupOeiFuMAoOJ2uG/s9m58rFvohlYzZHXLd4lhYWFAzD75f99tXCCMmMQ758ZNOaVLg3nFh8XeTykJib42npX5kTvxJSyzdqv8MnkTGsMXXi0mcFSh+gIwm91isY6uoBizpBP3tfDUF1Xi26lZtBd3nG1s3AY+NN8UrWv3zYl0beVKfzk/BJ878DKyVMHN+lslBvdFLCxoqcvtn0+Na+2mLrgYZiY0NYS035ywLs4n4I1lmEcyB7dl8l2XkTdTEhXQoK3diHDrigYJmvyRc26Zk4AAvw2DmBq6Q==;5:TuiOYRmVJdteCd8cM64ZKPfKBRfverlYvyNizxInRMhymCHwtkr+EDvKTWgpHztBJphdB6MfTNrjvS3sGoSK4MP2gIr89wzSZAAzuumMNc6ltnV1TXHdfaup0z6mRMaW1RLEeRnaNf4z3js/JiOoNw==;24:/nXZ2k0duIR7VsenIhvwfH2xHKseQx4nz3ed6Ma/Tcoc+LQdmFuqNop/Q39iNFvEQ0IoJ8ry/XZz9F5C2CQna8fyqCJBCoKW3kK8JjBdZr0=;7:9qZX4UICzkMLq/ZDJ5D0WQ2Lc+k8E625zH2L1imTa072x1w5A/e2Y6REO3bc5EknawnfDU4AbCtx2z4mTg7scWZh28G37njlVabL9w85074+ju+6kA1a/ZhkSX5XZ8fbXJpGGqS9OE6VhsCoPXeiOJhKjwQU/ML1wcXrG1koMjbBjtiAcHLjtUDRMbv7bkk26PzRozwTZhpKDuKdJYqc5zEMO8QGv7BEJBdqA7dhWJ8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1292;20:aJrjV4aGZMqQclEiOiLCl8VWu9WyOY/EtKhh2EI2sLO1Q1cYqOWdvmW/d8wIqIqezbzfdrahzMiMHRKK5zvSLtTp9GdscBodUtVcvqFh4CDlndVyuYGxQdZtZ4Ha5nwRM/lm8Jnd8OqTCX5s/sbKAmpQfqjnOA3DKtOJZ434s3w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2017 12:51:04.6281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1292 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-18_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/17 1:14 PM, Eric Dumazet wrote: > On Fri, 2017-08-18 at 03:21 -0700, Stéphan Gorget wrote: >> Those counters are exported for raw and udp but not for tcp, though they >> are incremented. >> >> An example where it is useful is chasing listen overflow. Listen overflow >> are counted as a global counter in LINUX_MIB_LISTENOVERFLOWS accessible >> in /proc/net/netstat but there is no way to find related drops in the >> information exported for tcp. With this patch it will make possible to >> correlate growth of LINUX_MIB_LISTENOVERFLOWS with growth of drops for >> a tcp socket. > > Simply use iproute2/ss tool to access this information in a very > efficient way (like filtering done in the kernel, instead having to > parse a gigantic /proc output) > > lpaa5:~# ss -tm state listening src :22 Thanks for the quick response, I'll use ss with those options that's exactly what I needed.